git-review icon indicating copy to clipboard operation
git-review copied to clipboard

Authentication error with two-factor authentication enabled

Open cornelius opened this issue 11 years ago • 2 comments

How to reproduce: Enable two-factor authentication. On a system, which hasn't set up git-review for authenitcated access to GitHub yet call a git review command, which needs authentication on the server. It asks for username and password on the command line, but then fails with the error "You provided the wrong username/password".

Disable two-factor authentication again, and it works as expected.

After enabling two-factor authentication again, it continues to work.

cornelius avatar Jan 30 '14 11:01 cornelius

The fix has been merged into the development branch. Gimme a couple of days to figure out whether I can merge the current dev branch completely into a new version of git-review or if I just cherry pick the fix.

b4mboo avatar Mar 28 '14 13:03 b4mboo

OK, "a couple of days" went by quickly. Since we just talked about this yesterday, I tested the current state and realized I need to fix a couple of things before a new version of git-review can be released. Sorry for the delay. I'm gonna work on getting a new version out soon.

b4mboo avatar Jul 02 '14 08:07 b4mboo