git-review icon indicating copy to clipboard operation
git-review copied to clipboard

Published 20 hours ago • verified publisher icon b4mboo

command 'close' not working if issues are closed for that repo

Open b4mboo opened this issue 12 years ago • 1 comments

This actually a GitHub bug, which I already reported. Just waiting for the fix.

b4mboo avatar Jun 20 '12 14:06 b4mboo

They fixed it by adding an option to close a PR without trying to close the issue. So in our code we need to change github.close_issue(repo, request.number) to github.close_pull_request(repo, request.number).

b4mboo avatar Aug 30 '13 13:08 b4mboo