disco icon indicating copy to clipboard operation
disco copied to clipboard

Newer release on pypi

Open Celelibi opened this issue 4 years ago • 4 comments

Hello,

I guess this is more or less a follow up on issue #170.

Installing disco-py from pip prove to be challenging. The version on pypi depends on an older version of gevent. This older version of gevent doesn't compile with python 3.8.

So, it's pretty much uninstallable from the pypi repository on any system that adopted python 3.8 already.

Celelibi avatar Apr 01 '20 05:04 Celelibi

I just ran into this same issue trying to troubleshoot for a friend; the install does indeed fail under Python 3.8.

Nekkowe avatar Apr 19 '20 08:04 Nekkowe

In accordance with issue #107, downgrading to 3.7 allowed us to install disco via the github branch. Trying to install via pip did not work on either 3.8 nor 3.7.

Nekkowe avatar Apr 19 '20 08:04 Nekkowe

Is there any reason why requirements.txt are pinned? Based on browsing a few closed issues and PRs, it seems it may be a good idea to change https://github.com/b1naryth1ef/disco/blob/master/requirements.txt#L1 to say e.g. gevent>=1.3.0 to prevent these issues in future...

The same goes for the other dependencies too (>= not ==).

casperdcl avatar Sep 20 '20 20:09 casperdcl

Found the time to release 0.0.14 rc1 which is built off the latest master. If things look fine in a few days I'll cut a 0.0.14 as a final "maintenance mode" release.

b1naryth1ef avatar Oct 27 '20 20:10 b1naryth1ef