powerline-shell icon indicating copy to clipboard operation
powerline-shell copied to clipboard

Published 20 hours ago • verified publisher icon b-ryan

Improve hostname colorization

Open ultravail opened this issue 5 years ago • 2 comments

There are 2 changes included:

a) The function getOppositeColor in color_compliment.py did not work properly. It was mixing value ranges from 0-1 and ranges from 0-255.

b) When hostname colorization is enabled, then a random number is being generated for the foreground color of the hostname and the opposite color is being calculated for the background color.

However, when running in a shell with dark background color it typically looks better if the background color of the hostname is "bright". So I introduced a noption in the configuration named "hostname.dark" that (when set to true) picks the brighter of the two colors for the hostname as the background color (by swapping the two if the foreground color is the brighter one in the first place).

ultravail avatar Sep 20 '19 11:09 ultravail

This would be great to have... I keep getting unreadable hostnames, making this functionality useless.

@b-ryan (or other maintainers) - any reason this isn't being merged?

Nicholas-Autio-Mitchell avatar Jan 10 '20 16:01 Nicholas-Autio-Mitchell

I have the same issue with unreadable hostnames. But I am not sure if this PR solves this.

You might take a look at this issue. https://github.com/b-ryan/powerline-shell/issues/381

CWempe avatar Jan 10 '20 19:01 CWempe