b-reyes
b-reyes
After merging #799, portions of our tests are failing. After looking into the failing tests, I found that when we install echopype on our GitHub builds, we get this strange...
In PR #774 we added the option to directly write variables with a large memory footprint to a temporary zarr store. Ideally, we want to include the option `offload_to_zarr='auto'`, which...
In PR #297 we created the function [_clean_ping_time](https://github.com/OSOceanAcoustics/echopype/blob/828587df6f49c6b7e49cef6d4af9246fc2e0be19/echopype/qc/api.py#L4), but did not include documentation. This function involves a recursive call, so it is not apparent what is happening. After discussing this...
In PR #794, it was found that RAW4 datagrams are not being correctly handled in the parsed to zarr (P2Z) method introduced in PR #774. The issue was discovered after...
While looking into PR #674, it was found that currently we only store the `raw_file` path from `open_raw` as an attribute (after PR #674 this will become the variable `ed.provenance.source_filenames`)....
In `combine_echodata` we currently gather the source file names using `echodata.source_file` and then these variables are put into the new combined `echodata.provenance.source_filenames` (this variable will exist once PR #674 has...
In PR #774 we added the functionality that allows users to directly write variables with a large memory footprint directly to a temporary zarr store. Currently, we have only applied...
In PR #658 it was found that the beam group descriptions for EK80 can become more specific. As it stands right now, we let the `Beam_group1` description be "contains backscatter...
In `combine_echodata` for some groups we use the function `xr.combine_nested`, which uses `concat_dims` from `echopype/core.py`. As of right now, it appears that we are always using the `default` key in...
While reviewing the `Sonar` group across the sensors, I noticed that there is a slight inconsistency in what is an attribute and what is a variable. For EK80 we have...