Ubuntu-media-tree-kernel-builder icon indicating copy to clipboard operation
Ubuntu-media-tree-kernel-builder copied to clipboard

Upstream drivers ?

Open CvH opened this issue 7 years ago • 34 comments

Hi, I am curious if there are any plans to "upstream" your drivers ? As OS maintainer I got several requests from users for those devices but unfortunately no proper solution yet. To add 20+ patches to the buildsystem doesn't sounds like a good idea long and midterm if there is no "timeframe" for upstreaming.

best regards

CvH avatar Oct 29 '17 18:10 CvH

Apologies, the v4l2-core-Reverse-758d90e16-kvmalloc patch derailed upstreaming efforts for some months. I had too many other projects to manage and couldn't dedicate the time to find root of the problem. I didn't realize it was a core issue, and the effects were anything from GPF to invalid opcode to random oopses depending on the machine. Now that I've determined it is not any of my patches they will be heading to the mailing list for review soon.

b-rad-NDi avatar Oct 30 '17 16:10 b-rad-NDi

@b-rad-NDi thanks for reply, good to hear :) I was asking because several "other" brands just do nothing to upstream and that creates a real mess downstream. I guess nobody is too much happy to do that game again and again ;) Will add support to LE as soon your patches hit media_tree, thanks for your work !

CvH avatar Oct 30 '17 17:10 CvH

The point of this project is to get Hauppauge back in the thick of things. We do not have a dedicated upstreamer, and unfortunately it is too easy to neglect upstream when there's so many other responsibilities in a smaller company. Thankfully the interest generated in this has further convinced my bosses of the importance of me absorbing the part. Keep an eye out, I hope most of the patches will be submitted within the next couple weeks.

b-rad-NDi avatar Oct 30 '17 17:10 b-rad-NDi

I'd echo @CvH I also am involved in maintaining DVB drivers for an OS and I find it difficult to recommend Hauppauge at the moment as it's a Slackware based OS and the Hauppauge driver situation is not great.

I'd be far more likely to recommend your hardware for the growing Linux PVR enthusiast market with upstream support or at least an easier driver package.

CHBMB avatar Oct 30 '17 21:10 CHBMB

I've been trying to get someone with the equipment to review them for months. It's nothing to do with my bosses any more.

b-rad-NDi avatar Oct 31 '17 17:10 b-rad-NDi

Good luck! :+1:

CHBMB avatar Oct 31 '17 19:10 CHBMB

btw, this is my personal github, unrelated to the company completely. If you'd like to request support from Hauppauge for anything, such as slackware support, especially so my bosses see it, you should file a support ticket with the company.

b-rad-NDi avatar Nov 01 '17 08:11 b-rad-NDi

Happy to do so if it helps you out. Would mentioning anything in particular be helpful to your cause?

CHBMB avatar Nov 01 '17 19:11 CHBMB

Anything you can think of to further impress on them the importance of me continuing driver development and upstream work helps.

b-rad-NDi avatar Nov 01 '17 21:11 b-rad-NDi

Long process of authorship research is complete. Authorization received from any involved parties.

Initial batch of 9 patches sent upstream. A ton more to follow tomorrow :)

b-rad-NDi avatar Jan 05 '18 00:01 b-rad-NDi

awesome news :)

CvH avatar Jan 05 '18 09:01 CvH

Thank you very much, Brad! Great work! Let's hope your patches will soon be accepted by the kernel maintainers.

gentoolinux avatar Jan 05 '18 15:01 gentoolinux

@b-rad-NDi Can't wait for the dual-HD support :D Thanks again for all the wonderful work you have done for Hauppauge and the community.

parkerlreed avatar Jan 05 '18 22:01 parkerlreed

Well done that man!

CHBMB avatar Jan 06 '18 01:01 CHBMB

All new devices submitted. Only things left are:

  • analog: will probably require work
  • ~~second frontend on 975~~
  • bits and bobs of leftover opimizations

b-rad-NDi avatar Jan 09 '18 16:01 b-rad-NDi

@b-rad-NDi :heart: https://www.spinics.net/lists/linux-media/msg127060.html

parkerlreed avatar Jan 10 '18 02:01 parkerlreed

30 patches submitted, 10 to go.

b-rad-NDi avatar Jan 12 '18 20:01 b-rad-NDi

Only took 60 days and my patches have finally started working into mainline from patchwork :D

b-rad-NDi avatar Mar 06 '18 14:03 b-rad-NDi

@b-rad-NDi do you maintain an recent patch tree patches/mainline-extra/tip/ here ? (easier to grab all still need patches)

CvH avatar Mar 06 '18 14:03 CvH

Once I work through the merge today and clean out what is in patchwork I will do some house cleaning.

b-rad-NDi avatar Mar 06 '18 14:03 b-rad-NDi

As it is right now everything in patches/mainline-extra/tip is exactly what is (was) in patchwork

b-rad-NDi avatar Mar 06 '18 14:03 b-rad-NDi

yea tx :)

CvH avatar Mar 06 '18 17:03 CvH

All patches have been sorted into series directories. The moment my 'missing bits' series gets merged into mainline I will be removing the following sets:

- 01.em28xx.dual.hd
- 02.spectral.inversion
- 03.935.and.975
- 04.975.second.frontend
- 05.new.pcie.devices
- 06.cx25840.extra.clocking.option

b-rad-NDi avatar Mar 06 '18 21:03 b-rad-NDi

The moment my 'missing bits' series gets merged into mainline I will be removing the following sets:

Hmm I guess you are too quick :> another 12 patches got merged

CvH avatar Mar 07 '18 09:03 CvH

:-D Will pull fresh media tree and clean house today.

b-rad-NDi avatar Mar 07 '18 17:03 b-rad-NDi

All upstreamed patch sets removed :)

b-rad-NDi avatar Mar 09 '18 20:03 b-rad-NDi

@b-rad-NDi Thanks for all your hard work on this. Much appreciated.

CHBMB avatar Mar 10 '18 07:03 CHBMB

Progress report;

  • Analog set still WiP, goal this week.
  • Ryzen DMA set, submitting upstream tomorrow
  • Random patches - some queued upstream, some WiP
  • ~~cx231xx - queued upstream~~ upstream
  • stat patches: WiP

b-rad-NDi avatar May 06 '18 22:05 b-rad-NDi

tx for your efforts, are the other patches just "forgotten" upstream or why are they so long at limbo ?

CvH avatar May 07 '18 08:05 CvH

A set or two is submitted at a time, to ensure minimal collisions. The first set took over two months to be accepted, and the remaining sets required additional testing and fixes. Plus that whole "time" thing. Some of my recent patches were picked up very quickly, so maybe the pace will get better.

b-rad-NDi avatar May 07 '18 15:05 b-rad-NDi