Johannes Hofmann

Results 20 comments of Johannes Hofmann

Hey @nyurik, that's a great project! I will try to find some time to look into it.

Thanks for these ideas. They definitely make the code more readable. Although I'm not sure if I want to introduce another dependency for that. Would you be okay with adding...

I like the idea of having a crate that handles everything surrounding delta encoding. But for this crate (osmpbf) right now, there is only a very narrow use-case: Adding/subtracting two...

I would like to keep AppVeyor around. There is already so much functionality concentrated on the GitHub platform. I'm still sad that Travis is not as easily available anymore. I'm...

Hi @nyurik, thanks for all the PRs and feature ideas. I know I haven't been that responsive lately. But I'm still dedicated to this project and not ready to transfer...

Thanks for this issue! A lot of OSM ways actually represent polygons (e.g., buildings) by specifying a closed way where the first and last node are identical: https://wiki.openstreetmap.org/wiki/Way#Closed_way_(closed_polyline) So this...

You should try using `IndexedReader::read_ways_and_deps` if you want to filter ways and also get the corresponding nodes: https://docs.rs/osmpbf/0.3.3/osmpbf/indexed/struct.IndexedReader.html#method.read_ways_and_deps

Thanks for this PR! Could you add a simple test to https://github.com/b-r-u/osmpbf/blob/main/tests/read.rs ? Just like [read_blobs()](https://github.com/b-r-u/osmpbf/blob/fd55e640c274f3fdec81e4ff94fca92578ee3922/tests/read.rs#L207C4-L207C16) but using the `AsyncBlobReader`.

A streaming reader sounds great. Do you think it would be possible to implement the needed functionality in this crate without adding a big dependency? Maybe it can also be...