object-editor-react icon indicating copy to clipboard operation
object-editor-react copied to clipboard

Better strings

Open yorickreum opened this issue 5 years ago • 2 comments

This is probably not a appropriate fix, more an issue to discuss: In the JSON we manage with the tool, we have some strings that span multiple lines. This is not supported by the input-field. Hence, in my opinion, it'd be good to switch to textarea. Or maybe better: Create the possibility to pass own input field components? Would offer much more use cases...

By the way: I think React should be listed as a peer dependency inside the package.json – otherwise you can get in trouble with different mismatching React versions.

yorickreum avatar Oct 26 '19 18:10 yorickreum

Create the possibility to pass own input field components?

Great idea, @yorickreum. Check out #46 which adds support for this and should fit your <textarea> use case. That PR has an example which implements <textarea>.

If it looks alright, we can merge it and close this.

b-gran avatar Oct 26 '19 20:10 b-gran

Wow, that was fast. Looks quite good! Way better than my workaround. Thanks a lot, will test it as soon as possible.

yorickreum avatar Oct 26 '19 20:10 yorickreum