Benedikt Groß

Results 151 comments of Benedikt Groß

Ping: Did you test everything in https://github.com/hfg-gmuend/openmoji/tree/master/helpers#openmoji-helpers-scripts with node 20.10? I'm a bit hesitant to change the running system ... for no urgent need.

Very nice comparison table! Thanks! Just as usual there is not a lot of glory in fixing these nitty gritty issues. Not sure whether this will happen soon ...

Hi @sotha1, many thanks! Good call, yes your suggestions would definitely improve it, especially as other OpenMojis with masks eg. https://openmoji.org/library/emoji-E0AC-200D-2642-FE0F/ have a style like the one you suggested. Could...

Great! Here is some hyper specific feedback :) If we re-do the OpenMoji it would be nice to be really 100%. I hope you don't mind! - the upper mask...

Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers!

@sotha1 this is hard to debug from remote :) Hence please use the original source file and copy your changes over. Please see also https://openmoji.org/styleguide/ and especially https://openmoji.org/styleguide/#submission I hope...

Open the SVG and check that all elements e.g. rect, line, circle ... don't have any style attribute e.g. remove all `style="some css code"` the problem is that svg elements...

Super that the two of you starting to tackle this! Great! Small note: I would prefer less PRs than for every single flag a dedicated PR. Generating and checking is...

@Kirylchyk Great! Many thanks!