[FR]: Add Moonsighting Committee method

[Jds548]

Assalamu alaikum brother Thanks for your great program! Jazakallah khairan. Is there any chance to add Moonsighting Committee method? It Uses standard 18° angles for Fajr and Isha in addition to seasonal adjustment values (1).

[azzamsa]

I think it is not as simple as adding the method in:

• https://github.com/batoulapps/adhan-js/blob/67e4cb4b771f6309c9cb88eaf98f261116fe32ba/src/CalculationMethod.ts#L44
• https://github.com/azzamsa/islam/blob/8b00b9fcf61b9e507a894c13e2ad872a870b7b9c/src/salah/method.rs#L42

But there are also some adjustments for certain cases:

• https://github.com/batoulapps/adhan-js/blob/67e4cb4b771f6309c9cb88eaf98f261116fe32ba/src/PrayerTimes.ts#L122

Bilal is built on top of Islam which is a direct port of pyIslam. if we can ask @abougouffa to add the Moonsighting Committee method to pyIslam, it would be easy for me to add it to Islam.rs

[Jds548]

if we can ask @abougouffa to add the Moonsighting Committee method to pyIslam, it would be easy for me to add it to Islam.rs

Thanks for your reply. I've made the request.

[abougouffa]

Hi @Jds548 and @azzamsa

The Moonsighting Committee method is a bit different from the rest of the methods (the other methods differ generally only in a value for the angle used for Fajr and Ishaa).

I've already implemented this in an Emacs package (https://github.com/zkry/awqat/blob/master/awqat.el), so I think I can do it here also.

Since I'm not actively maintaining my pyIslam package, and the code quality of it is not that great (I started it when I was in high school!). I think I will implement it directly in @azzamsa's islam library.

Please keep this issue open, I will try to work on it ASAP!