react-dnd-scrollzone icon indicating copy to clipboard operation
react-dnd-scrollzone copied to clipboard

Support latest versions of react-dnd, and other fixes

Open eaglus opened this issue 6 years ago • 16 comments

react-dnd-scrollzone don't work with react-dnd >= 4.0.0, because it uses new React context API (Provider/Consumer from React 16.3).

This PR add support latest versions of react-dnd, which uses new React context API, and still supports old react-dnd version, which uses old-style context api.

Another changes:

Add getScrollContainer - optional parameter: a function that returns scrolling container (useful for complex custom scroll components). It recieves one argument: root node of wrapped mounted component. Add typings for Typescript Add sideEffects: false parameter to package.json to optimize Webpack4 bundles

eaglus avatar Sep 11 '18 13:09 eaglus

@eaglus unfortunately, it doesn't look like this repo is being maintained any more 😞

tysonnero avatar Sep 22 '18 01:09 tysonnero

Please merge this PR @nickclaw :+1: this would be great!

seanchambo avatar Oct 15 '18 23:10 seanchambo

Sorry! I no longer work at Azuqua so I don't have push access.

nickclaw avatar Oct 16 '18 03:10 nickclaw

Sorry! I no longer work at Azuqua so I don't have push access.

Hi Nick! Can you ask them to merge this PR? Does anybody have access to this repository?

eaglus avatar Oct 16 '18 06:10 eaglus

Does anybody have access to this repository? Please merge this @gulderov @criticerz @mattkrick @fritz-c @jas-per @Mathieuu

eaglus avatar Oct 16 '18 06:10 eaglus

Hi @eaglus, we will take a look at the changes this week. At a minimum the package major version needs to be increased, and we will review further when time permits.

maxcutler avatar Oct 16 '18 15:10 maxcutler

@eaglus any chance of doing this mate so we can get this pushed through?

seanchambo avatar Oct 18 '18 05:10 seanchambo

@eaglus any chance of doing this mate so we can get this pushed through? I hope they will review this PR and merge it: @gulderov @criticerz @mattkrick @fritz-c @jas-per @Mathieuu

eaglus avatar Oct 18 '18 11:10 eaglus

Please merge this, @azuqua-bot @aembke @j-crowe @jaredallard @kevinwilson541 @UnbounDev

eljenso avatar Oct 28 '18 11:10 eljenso

Please merge this, @azuqua-bot @aembke @j-crowe @jaredallard @kevinwilson541 @UnbounDev

eaglus avatar Oct 30 '18 16:10 eaglus

I'm sorry for the delay in getting this reviewed, our team has been busy with other commitments. At this point I cannot commit to a particular timeline for reviewing, merging, and publishing these changes; if you have time pressures of your own, you should consider maintaining your own fork instead.

Spamming other Azuqua employees is not an effective way to request progress on PR reviews, especially when they are not members of the team that uses this library.

maxcutler avatar Oct 30 '18 17:10 maxcutler

I'm sorry for the delay in getting this reviewed, our team has been busy with other commitments. At this point I cannot commit to a particular timeline for reviewing, merging, and publishing these changes; if you have time pressures of your own, you should consider maintaining your own fork instead.

Spamming other Azuqua employees is not an effective way to request progress on PR reviews, especially when they are not members of the team that uses this library.

Sorry for spamming, @maxcutler ... We wish you to finish your commitments and hope you will merge this PR soon.

eaglus avatar Oct 31 '18 13:10 eaglus

@azuqua-bot , @maxcutler Hi Max! We still hope for your review of this PR. Maybe some other members of azuqua may review and merge it?

eaglus avatar Nov 22 '18 13:11 eaglus

Hi, I was wondering if it would it be possible to move this repo to the react-dnd organization so that other people could help to maintain it and merge PRs? Thanks!

ndbroadbent avatar Nov 20 '19 12:11 ndbroadbent

Scrolling down on IOS 13 is broken in the older versions of react-dnd, so was forced to update it, So I also need this fix... 😄

Axosoft-Ashley avatar Dec 19 '19 20:12 Axosoft-Ashley

Hi everyone, I'd suggest that if you need this work done that you fork this to the react-dnd org or some other org. :smile:

jaredallard avatar Dec 19 '19 20:12 jaredallard