terraform-provider-azurecaf icon indicating copy to clipboard operation
terraform-provider-azurecaf copied to clipboard

Add support for updates to resource type(s) with auto-upgrade support

Open owenfarrell opened this issue 2 years ago • 3 comments

Signed-off-by: Owen Farrell [email protected]

Fixes #140 Supercedes: #196

PR Checklist


  • [x] I have read the CONTRIBUTING.MD instructions
  • [ ] I have changed the resourceDefinition.json
  • [ ] I have generated the resource model (there's a models_generated.go file in my PR)
  • [ ] I have updated the README.md#resource-status
  • [x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • [ ] YES
  • [x] NO

While this doesn't inherently introduce a backwards-breaking change, I'm not sure that my attempt at an auto-upgrade is a sure thing. The approach that I used was a bit of a "guess and check" based on the existing outputs. In a worst case scenarios, anyone who attempts to auto-upgrade will incur the existing behavior (a forced deletion/recreation of downstream resources) one last time. Any suggestions on how to mitigate this issue would be appreciated.

Testing

In addition to local unit testing, I've exercised these updates via a local provider override and it seems to meet the need.

$ make build
go generate

2022/11/02 12:22:28 File generated
go fmt ./...
azurecaf/data_environment_variable.go
azurecaf/models_generated.go
azurecaf/provider_test.go
go build -o ./terraform-provider-azurecaf
go test ./...
?       github.com/aztfmod/terraform-provider-azurecaf  [no test files]
ok      github.com/aztfmod/terraform-provider-azurecaf/azurecaf 24.284s
?       github.com/aztfmod/terraform-provider-azurecaf/completness      [no test files]

owenfarrell avatar Nov 02 '22 16:11 owenfarrell

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
26.7% 26.7% Duplication

sonarqubecloud[bot] avatar Nov 29 '22 18:11 sonarqubecloud[bot]

any update on this enhancement? this would save a lot of headaches for folks who didnt notice this behavior and encountered significant cascading impacts (resource re-creation)

patpicos avatar Jul 20 '23 15:07 patpicos

Quality Gate Failed Quality Gate failed

Failed conditions
20.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 13 '24 03:03 sonarqubecloud[bot]