terraform-azurerm-caf
terraform-azurerm-caf copied to clipboard
Fix api_management_custom_domain warning, AKS - Add public_network_access_enabled, Redis Managed Identities and Postgresql-flexible Database name
Issues
Bug report-proxy is deprecated and will be renamed to gateway in version 3.0 of the AzureRM provider # 1317 Unable to create Postgres flexible server databases with underscore # 950 & fix(resourceDefinition.json) allow underscores within azurerm_key_vault_secret 189 Feature request - AKS - Add public_network_access_enabled flag # 1324 Feature request - Add support to Managed Identities and replicas_per_{master, primary} / Redis append-only file feature flags # 1330 Feature request - Remote AD Group for AKS Admin Groups #1256 Bug report-Incorrect private_subnet_network_security_group_association_id being added#1353
PR Checklist
- [ ] I have added example(s) inside the [./examples/] folder
- [ ] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
- [X] I have checked the coding conventions as per the wiki
- [X] I have checked to ensure there aren't other open Pull Requests for the same update/change?
Description
Fix deprecated Warning "proxy is deprecated and will be renamed to gateway in version 3.0 of the AzureRM provider"
Does this introduce a breaking change
- [ ] YES
- [X] NO
Testing
@arnaudlh Any timeline for including these changes please?
@LaurentLesle Any update on this PR review please?
@arnaudlh @LaurentLesle Any idea when this PR will be approved, please?
@arnaudlh @LaurentLesle any updates on this PR please - its several months now.
@nusrath432 I have changed the target branch for your PR. Can you merged int-5.7.0 into you branch to fix the conflicts? Then I think we are good to go.
@LaurentLesle @arnaudlh Conflicts resolved. Ta
@LaurentLesle I have updated the code as per your comments - unfortunately I have no access to a tenant to test.