terraform-azurerm-caf icon indicating copy to clipboard operation
terraform-azurerm-caf copied to clipboard

Fix api_management_custom_domain warning, AKS - Add public_network_access_enabled, Redis Managed Identities and Postgresql-flexible Database name

Open nusrath432 opened this issue 2 years ago • 1 comments

Issues

Bug report-proxy is deprecated and will be renamed to gateway in version 3.0 of the AzureRM provider # 1317 Unable to create Postgres flexible server databases with underscore # 950 & fix(resourceDefinition.json) allow underscores within azurerm_key_vault_secret 189 Feature request - AKS - Add public_network_access_enabled flag # 1324 Feature request - Add support to Managed Identities and replicas_per_{master, primary} / Redis append-only file feature flags # 1330 Feature request - Remote AD Group for AKS Admin Groups #1256 Bug report-Incorrect private_subnet_network_security_group_association_id being added#1353

PR Checklist


  • [ ] I have added example(s) inside the [./examples/] folder
  • [ ] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
  • [X] I have checked the coding conventions as per the wiki
  • [X] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Fix deprecated Warning "proxy is deprecated and will be renamed to gateway in version 3.0 of the AzureRM provider"

Does this introduce a breaking change

  • [ ] YES
  • [X] NO

Testing

nusrath432 avatar Aug 30 '22 16:08 nusrath432

@arnaudlh Any timeline for including these changes please?

nusrath432 avatar Oct 03 '22 14:10 nusrath432

@LaurentLesle Any update on this PR review please?

nusrath432 avatar Nov 17 '22 10:11 nusrath432

@arnaudlh @LaurentLesle Any idea when this PR will be approved, please?

nusrath432 avatar Dec 18 '22 23:12 nusrath432

@arnaudlh @LaurentLesle any updates on this PR please - its several months now.

nusrath432 avatar Jan 20 '23 19:01 nusrath432

@nusrath432 I have changed the target branch for your PR. Can you merged int-5.7.0 into you branch to fix the conflicts? Then I think we are good to go.

LaurentLesle avatar Apr 28 '23 05:04 LaurentLesle

@LaurentLesle @arnaudlh Conflicts resolved. Ta

nusrath432 avatar Apr 28 '23 23:04 nusrath432

@LaurentLesle I have updated the code as per your comments - unfortunately I have no access to a tenant to test.

nusrath432 avatar May 04 '23 21:05 nusrath432