Saif Eddin Gmati

Results 156 comments of Saif Eddin Gmati

for reference, you can look at https://github.com/Roave/BackwardCompatibilityCheck/pull/306 and https://github.com/laminas/automatic-releases/pull/138

this issues is probably related to remote settings, `Go to definition` works fine on Linux, and MacOS. i don't have windows, but i think you configurations are wrong. > "hack.remote.enabled":...

> autocomplete symbols from all namespaces, while suggesting the nearest symbols fist. autocompletion works only with current namespace, and child namespaces ( not grand childs, or parent namespace ) suggestions...

not sure if amphp/mysql suffers from this issue as well, as i have been mostly playing around with amphp/postgres lately, though, i would assume it does.

> while arguably the initial query shouldn't have been made within a transaction, remember that this is just an example. This is just an example, `$users` could have been returned...

> Using a Transaction object for a service is certainly problematic That doesn't have to be the case, e.g: using [`Neu\Database\DatabaseInterface`](https://github.com/neutomic/neu/blob/feat/database/src/Database/DatabaseInterface.php#L25) ( still early in dev, so the API is...

and this is a proof that solution 2 doesn't work :), i agree on going with 1, with a clear error message ( on where the commit()/rollback() happened that resulted...

Hm 🤔 commit doesn't decrement the refCount, is it supposed to?

decrementing the refCount on commit/rollback also fixes this problem, so I'm not sure which one is the correct fix.