Saif Eddin Gmati comments

Results 156 comments of


                                            Saif Eddin Gmati

Result is too restrictive, introduce Either type?

what do you think about the other ones ( `*Or`, `*OrElse`, `*OrThen` )?

Result is too restrictive, introduce Either type?

@someniatko `Option` implemented in #356, would appreciate your review :)

OSX: `Filesystem\create_temporary_file(Env\temp_dir()))` not equivalent to `\tempnam(\sys_get_temp_dir())`

so it seems `tempnam` resolves symlink, while Filesystem\create_temporary_file doesn't. Not sure if we should 🤔 currently `create_temporary_file` doesn't use `tempnam`, and i don't really see a gain from using it.

chore(macro): Deprecate global state in macro system

@davidcole1340 what is the status here? anything i can do to help? :)

chore(macro): Deprecate global state in macro system

I have actually tested it a bit today :D seems good to me

DateTime API

> Waiting for a stable DateTime API to emerge in the hsl would be... ill-advised. Go ahead a forge your own path. I have already figured since development has stopped...

Type\not_null()

this won't be possible, as psalm doesn't have a type that includes everything but not null 🤔

Type\not_null()

we could close this issue, and open a new one in the plugin repository to add support for type narrowing when `Type\not_null()` is used? wdyt @veewee ?

Think of a better name...?

PAC - PHP AOT Compiler

Still maintained? And if yes is there a chance a 1.0 will be released soon?

Yes, i'm planning on cleaning up the repository and releasing 1.0, however, i didn't have time to do so yet, hopefully i can get to it soon :)