BetterFindBuffer icon indicating copy to clipboard operation
BetterFindBuffer copied to clipboard

Add dark theme

Open stoivo opened this issue 8 years ago • 21 comments

closes #26

screen shot 2016-12-08 at 20 51 41

stoivo avatar Dec 08 '16 19:12 stoivo

As you can see I am not a pro designer but it looks better then the bright one to me.

Do you want me to add a screenshot to README.md?

stoivo avatar Dec 08 '16 19:12 stoivo

ping

stoivo avatar Jan 06 '17 00:01 stoivo

@aziz @Kl0tl

stoivo avatar Jan 20 '17 13:01 stoivo

Please darken the red background on the file name a bit. Otherwise this does the job.

FichteFoll avatar Jan 29 '17 22:01 FichteFoll

I don't like the colors, I'm not gonna merge this. make something more decent based on one of the popular dark themes and I'll merge it

aziz avatar Jan 29 '17 22:01 aziz

This took too much time. Is this good? screen shot 2017-05-26 at 00 22 52

My preferred theme is Tubnil.

stoivo avatar May 25 '17 22:05 stoivo

Thoughts?

stoivo avatar Jun 01 '17 12:06 stoivo

@nivir, any thoughts?

stoivo avatar Jun 07 '17 10:06 stoivo

@stoivo personally I never like the dark background and red color, not sure what you can improve. For me I am happy as it is now with Mac Classic.tmTheme :)

nivir avatar Jun 07 '17 10:06 nivir

screen shot 2017-06-07 at 12 43 13

stoivo avatar Jun 07 '17 10:06 stoivo

Since I'm also a tubnil user, purple and pink are perfectly fine for me. I also considered the red to be too offensive and distracting before.

FichteFoll avatar Jun 07 '17 10:06 FichteFoll

I agree, it was too offensive.

stoivo avatar Jun 08 '17 06:06 stoivo

ping

stoivo avatar Aug 18 '17 13:08 stoivo

pong @aziz @FichteFoll

stoivo avatar Sep 10 '17 16:09 stoivo

I am tired of waiting, any feedback is better than this...

stoivo avatar Oct 06 '17 11:10 stoivo

Not my repo, but I mentioned earlier that I like the latest iteration of this.

Generally, it would seem better to have the custom syntax definition use some of the standardized scope names instead of having to bundle custom color schemes, but this would need some exploration. Having a bright and dark scheme should work as a band-aid.

FichteFoll avatar Oct 10 '17 16:10 FichteFoll

@aziz hello

stoivo avatar Nov 28 '17 07:11 stoivo

ping @aziz

stoivo avatar Jun 08 '18 07:06 stoivo

Ideally the custom syntax would just use normal scope names and region.<color>ish scopes for emphasis of specific areas if needed. That way no scheme overrides are necessary and it will work on every scheme, bright or dark.

FichteFoll avatar Jun 08 '18 19:06 FichteFoll

@FichteFoll, I might take a look at that. If/when I get the time.

stoivo avatar Jun 08 '18 20:06 stoivo

Honestly, why has this still not been implemented? The hard work was already taken care of. At least implement this temporary workaround. Such a crucial plugin needs better styling.

Why can't this plugin simply leave the styling to the app's default, basically matching the user's currently applied Sublime Text theme? That could happen by not including any styling, or perhaps setting this plugin's styling to match the app's.

Koolstr avatar Nov 12 '18 22:11 Koolstr