azerothcore
Fix Compile Issue and Update Trainers/SQL
This removes the useless innkeeper and includes various other tweaks to the trainers. See commits for full details. This fixes #38.
Can you explain why the Innkeeper is useless? It will be used to set Hearthstone location right? that seems useful
Edit: Well okey you can teleport there with chat command anyway, so indeed useless.
Seems Notepad++ must have done me dirty with the indentation... I've committed the suggestions (let me know if I didn't do it properly, I'm not well-versed with GitHub flows). Please review and merge if possible, once this module is up to date with my own version again I can maybe look at some of the other requests such as custom IDs, especially since I'll have some free time this week. Thanks!
You could've merged them in one batch instead of several.
You only merged half of my suggestions. If you click "Expand" above between my outdated ones, there are more
CI errors
Script named 'GuildHouseSeller' is not assigned in the database. Script named 'GuildHouseSpawner' is not assigned in the database.
I don't know what that means
Also
This fixes https://github.com/azerothcore/mod-guildhouse/issues/38.
But, 38 has already been fixed by #40.
Actually I'm not sure how this PR can exists without merge conflict, when its changing GetGOData to GetGameObjectData, even though GetGameObjectData isn't even in the code anymore.