mod-eluna icon indicating copy to clipboard operation
mod-eluna copied to clipboard

RegisterInstanceEvent( instance_id, event, function ) does not fire

Open 55Honey opened this issue 3 years ago • 2 comments

Tested with

function InitInstance(event, instance_data, map)
    print("InitInstance 1")
end
function LoadInstance(event, instance_data, map)
    print("LoadInstance 2")
end
function UpdateInstance(event, instance_data, map)
    print("UpdateInstance 3")
end
function PlayerEnterInstance(event, instance_data, map)
    print("PlayerEnterInstance 4")
end
function CreatureCreateInInstance(event, instance_data, map)
    print("CreatureCreateInInstance 5")
end
function GOCreateInInstance(event, instance_data, map)
    print("GOCreateInInstance 6")
end
function EncounterInProgress(event, instance_data, map)
    print("EncounterInProgress 7")
end

RegisterInstanceEvent(36, 1, InitInstance, 0)
RegisterInstanceEvent(36, 2, LoadInstance, 0)
RegisterInstanceEvent(36, 3, UpdateInstance, 0)
RegisterInstanceEvent(36, 4, PlayerEnterInstance, 0)
RegisterInstanceEvent(36, 5, CreatureCreateInInstance, 0)
RegisterInstanceEvent(36, 6, GOCreateInInstance, 0)
RegisterInstanceEvent(36, 7, EncounterInProgress, 0)

https://github.com/azerothcore/mod-eluna/blob/684eb0335bacc81110e75e36830204dea90c45c3/src/ElunaLuaEngine_SC.cpp#L242

As you may see, sEluna->GetInstanceData is called to create a new instance data, but it is assigned to instanceData which is actually just a local variable.

55Honey avatar Sep 12 '22 18:09 55Honey

Is there a plan when this issue will be fixed?

kncxstudio avatar Mar 04 '23 17:03 kncxstudio

Mod-eluna and Azerothcore are open source projects. There is no schedule to fix certain issues and our voluntary contributors pick issues according to their skills and preferences. Anyone can provide a bounty for issues, if they wish to have it resolved as fast as possible.

55Honey avatar Mar 04 '23 18:03 55Honey