mod-eluna icon indicating copy to clipboard operation
mod-eluna copied to clipboard

Add GetReactState to CreatureMethods and GetKnownTaxiNodes, SetKnownTaxiNodes to PlayerMethods

Open Aldori15 opened this issue 10 months ago • 8 comments

We have the ability to SetReactState, but we don't have to ability to GetReactState.

Aldori15 avatar Feb 14 '25 20:02 Aldori15

Also added GetKnownTaxiNodes and SetKnownTaxiNodes to PlayerMethods.

All 3 functions have been tested by me and are currently in use in a couple of scripts utilizing Eluna.

Aldori15 avatar Feb 17 '25 03:02 Aldori15

I've merged recent changes FROM master into this PR to see if the build is ok. The PR wasn't merged into master yet, but i plan to when the build is green.

55Honey avatar Feb 20 '25 20:02 55Honey

The LuaJit build keeps failing here.

55Honey avatar Feb 23 '25 14:02 55Honey

Is there anything I need to do?

Aldori15 avatar Feb 24 '25 02:02 Aldori15

In LuaJIT, the luaL_len function, which is typically used to get the length of a table, does not exist.
LuaJIT is designed to be lightweight and more performance-focused, so certain functions from the standard Lua API (such as luaL_len) are not available in LuaJIT.
In standard Lua, luaL_len is defined in the lauxlib.h header and is used to get the length of a table (as in luaL_len(L, index)).
In LuaJIT, you should use lua_objlen instead of luaL_len to obtain the length of a table.

Looks like this requires an #IFDEF block.

55Honey avatar Feb 24 '25 19:02 55Honey

Can you try now with the newest commit?

image

Test code and Debug print showing retrieval of the table: image

image

Aldori15 avatar Feb 24 '25 20:02 Aldori15

Looks like it is green now :)

Aldori15 avatar Feb 25 '25 05:02 Aldori15

Let me know if anything else is needed here.

Aldori15 avatar Mar 08 '25 06:03 Aldori15

Is there anyone else that can approve this pull request? All checks have passed and I don't know if something else is waiting or needed.

Aldori15 avatar Apr 04 '25 21:04 Aldori15

Any update?

Aldori15 avatar May 12 '25 18:05 Aldori15

It doesn't appear this will ever get merged/completed. Closing out this PR and just going to continue to work off of my fork.

Aldori15 avatar Jun 23 '25 15:06 Aldori15