mod-duel-reset icon indicating copy to clipboard operation
mod-duel-reset copied to clipboard

Duelling outside SW does not reset mana while in druid's feral form.

Open Apathyxia opened this issue 1 year ago • 2 comments

When duelling someone outside of Stormwind as a druid and you're in a feral form (cat/bear), the mana is not reset to its maximum value. Health is reset normally. Mana is reset on duel start while in human form.

I did not test boomkin / tree form as I don't have those readily available as of now.

Apathyxia avatar Apr 03 '23 19:04 Apathyxia

I think this issue might be caused due to this line here:

void DuelReset::SaveManaBeforeDuel(Player* player) {
    if(!player)
        return;

  m_manaBeforeDuel[player] = player->GetPower(POWER_MANA);
}

if i understand it correctly, it tries to get player mana number, but due to being in feral form that doesnt use mana, it can't assign a value to it, thus failing to later reset mana.

Although I can see script checking if player is druid or has power_mana, i am unsure on how druid Power_mana is stored, when it is in feral form(cat or bear)

HasieEST avatar May 09 '23 15:05 HasieEST

Interesting topic... I would have to investigate more...

pangolp avatar Aug 03 '23 07:08 pangolp