mod-ah-bot icon indicating copy to clipboard operation
mod-ah-bot copied to clipboard

Bug: Only finds a single auction

Open Ithen opened this issue 1 year ago • 1 comments

Current Behaviour

No idea how git works, but i wanted to report this atleast.

There is a break in AuctionHouseBot.cpp on line 167. The bot only sees a single auction when looking at the total amount of auctions with ConsiderOnlyBotAuctions enabled.

Expected Behaviour

Should count all the auctions, not a single one.

Steps to reproduce the problem

Run current commit: b4e1653 on a fresh server.

Extra Notes

No response

AC rev. hash/commit

AC> AzerothCore rev. 2bab8ee80715 2024-12-25 22:41:10 +0800 (Playerbot branch) (Unix, Release, Static) Connected players: 1. Characters in world: 1. Connection peak: 1. Server uptime: 7 minute(s) 33 second(s) Update time diff: 1ms. Last 500 diffs summary: |- Mean: 1ms |- Median: 1ms |- Percentiles (95, 99, max): 4ms, 5ms, 39ms Using SSL version: OpenSSL 3.0.15 3 Sep 2024 (library: OpenSSL 3.0.15 3 Sep 2024) Using Boost version: 1.74.0 Using CMake version: 3.25.1 Using MySQL version: 80403 Found MySQL Executable: /usr/bin/mysql Compiled on: Linux 6.1.0-28-amd64 Worldserver listening connections on port 8085 Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true MMAPs status: Enabled maps directory located in ./maps. Total size: 291014951 bytes vmaps directory located in ./vmaps. Total size: 658130721 bytes mmaps directory located in ./mmaps. Total size: 2192910844 bytes Default DBC locale: enUS. All available DBC locales: enUS Using World DB: ACDB 335.13-dev Using Playerbots DB Revision: Latest LoginDatabase update: 2024_12_15_00.sql Latest CharacterDatabase update: playerbots_names.sql Latest WorldDatabase update: world_playerbots_rpg_races.sql LoginDatabase queue size: 0 CharacterDatabase queue size: 0 WorldDatabase queue size: 0 PlayerbotsDatabase queue size: 0 List of enabled modules: |- mod-ah-bot |- mod-eluna |- mod-playerbots |- mod-solo-lfg |- mod-weekendbonus

Operating system

Debian 12

Custom changes or Modules

No response

Ithen avatar Dec 25 '24 20:12 Ithen

Confirm tested on my side AuctionHouseBot::getNofAuctions will always return 1 if ConsiderOnlyBotAuctions == 1

Then the number of items in the AH will forever increase.

the break in if (guid == Aentry->owner) { count++; break; // THIS NEED TO BE REMOVED }

Jaytapp avatar Jan 03 '25 19:01 Jaytapp