mod-ah-bot icon indicating copy to clipboard operation
mod-ah-bot copied to clipboard

Feature: Move database settings to config file

Open AldebaraanMKII opened this issue 1 year ago • 2 comments

Describe your feature request or suggestion in detail

There`s no reason for some of the settings to be in the database. All of it should be in the configuration file.

Describe a possible solution to your feature or suggestion in detail

No response

Additional context

No response

AldebaraanMKII avatar Sep 15 '24 09:09 AldebaraanMKII

I also though about it, but did not find a suitable solution for this for the configuration of the houses. We got alliance, horde and neutral auction houses; what do you propose to handle their values?

Put alliance.XXX horde.XXX and neutral.XXX configuration inside the text file? This seems a little ugly honestly, but if you have some feedback about it we're open to discuss them.

kewinrausch avatar Sep 20 '24 18:09 kewinrausch

What I would do is create a AHBaseConfig with all values in it. And after a config override for specific AH Houses for values that differ from the base

Then initialize all the AH with the AHBaseConfig values. Then the AHHorde, AHNeutral, AHAlliance in the config file would have the config section but you only put values you want to override from the AHBaseConfig. Then override only the values in the specific section.

That way in the config file you have:

#AHBaseConfig AHBaseConfig.numberofitems AHBaseConfig.etc AHBaseConfig.etc ...

#Horde Overrides AHHorde.valueIwanTochangeFromBase

#AllianceOverride AHAlliance.someOtherValue

#NeutralAH #nothing same as base

Jaytapp avatar Jan 04 '25 16:01 Jaytapp