azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

ICC Saurfang combat start dialog with Muradin Bronzebeard are broken

Open zqgmzq opened this issue 3 years ago • 8 comments

Current Behaviour

ICC Saurfang combat start dialog Muradin Bronzebeard are broken

Expected Blizzlike Behaviour

ICC Saurfang combat start dialog Muradin Bronzebeard is ok

Source

No response

Steps to reproduce the problem

Go ICC Start batle with Saurfang

Extra Notes

No response

AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/commit/bfe290477ce4c4787555671021a1a280daf00be7

Operating system

Debian 10

Custom changes or Modules

No response

zqgmzq avatar Nov 03 '21 08:11 zqgmzq

I guess he is mixing Horde/Allince text WoWScrnShot_110421_185130

Wowwiki Saurfang quotes

Shineslippers avatar Nov 04 '21 15:11 Shineslippers

Another thing is - the ending of the fight is broken too.

After he dies, the Big Saurfang has to show up and take his son's body. Unfortunately, this script is absent, for both factions.

Not sure if i'm supposed to make a new topic about this or just say it here

Ravenguard13 avatar Nov 05 '21 20:11 Ravenguard13

@Azcobu it's "Content 80", not 60 ))))

Ravenguard13 avatar Nov 05 '21 21:11 Ravenguard13

It's auto. Don't understand. I labled it 80.

Shineslippers avatar Nov 05 '21 22:11 Shineslippers

If I make this query

UPDATE `creature` SET `id1`=37200 WHERE `guid`=200982;

The dialogue in the alliance is perfect. Although I will surely fail in the horde.

I'm not saying that should be the answer. But it's funny, how when you make that change, it "fixes itself" I think the problem is in the Creature::UpdateEntry. But I have already tried several times to find the solution and I have not been able to.

pangolp avatar May 02 '24 17:05 pangolp

Another change I made was this.

uint32 Creature::GetScriptId() const
{
    if (CreatureData const* creatureData = GetCreatureData())
        if (uint32 scriptId = creatureData->ScriptId)
            return scriptId;

    return sObjectMgr->GetCreatureTemplate(GetEntry())->ScriptID;
}

For this

uint32 Creature::GetScriptId() const
{
    return sObjectMgr->GetCreatureTemplate(GetEntry())->ScriptID;
}

In this way, I have managed to ensure that the gossip is read properly.

WoWScrnShot_050224_141513

WoWScrnShot_050224_141530

pangolp avatar May 02 '24 17:05 pangolp

https://github.com/azerothcore/azerothcore-wotlk/assets/2810187/e142c465-bec4-4516-9416-2b248b523721

WoWScrnShot_050224_142407

pangolp avatar May 02 '24 17:05 pangolp

I really don't know what else to try. On top of that I have a core from a few years ago, and this mechanic works well. I'm sure it has something to do with when the 3 ids were added to the creature table. But I have no way to reproduce the problem. I've already given up hope of being able to really track down the problem.

pangolp avatar May 03 '24 08:05 pangolp