azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

Feature: [Module] Log RDF meta data

Open 55Honey opened this issue 4 years ago • 6 comments

Describe your feature request or suggestion in detail

When players are automatically invited to a RDF group, the meta data of these events should be stored:

  • who joined/refused to join(playerGuid) and when (timestamp)
  • who left(playerGuid), also when (timestamp) and how (left on purpose, was kicked or disconnected)
  • what dungeon/raid

An optional config flag is required to turn the feature on.

Describe a possible solution to your Feature or Suggestion in detail

Storing the relevant data in the database would be convenient, as long as all above criteria regarding content and readability are met.

Additional context

55Honey avatar Apr 26 '21 10:04 55Honey

For what purpose?

Kitzunu avatar Apr 26 '21 12:04 Kitzunu

For what purpose?

moderation

FrancescoBorzi avatar Apr 26 '21 13:04 FrancescoBorzi

Should be fairly simple as core already does all this

Kitzunu avatar Apr 26 '21 13:04 Kitzunu

it would be nice to have this as a module, I'll add a bounty on this later

FrancescoBorzi avatar Apr 26 '21 14:04 FrancescoBorzi

Why module? We already log chat, gm commands, etc, just add a new config like them?

Kitzunu avatar Apr 26 '21 21:04 Kitzunu

Why module? We already log chat, gm commands, etc, just add a new config like them?

I can live with a new config for this. But, ideally, we should always have this kind of feature as a module.

Yes, I know, we already have plenty of similar features in the core. That's both for historical reasons (before AzerothCore there were no modules in mangos/trinitycore) and because it's simpler for some people to just throw features inside the core (partially it's also our fault, as the module and hooks system hasn't been properly documented so far - but we are working to improve that).

Modular software is easier to be maintained and there are a lot of benefits in splitting the code into modules instead of having a big "monster".

https://en.wikipedia.org/wiki/Modular_programming

FrancescoBorzi avatar Apr 27 '21 13:04 FrancescoBorzi