fix(DB/SAI): Rhydian spawns portal to Shattrath on quest 13081 accept
[!] Please Read! This PR comes from AI with MCP
Changes Proposed:
This PR proposes changes to:
- [ ] Core (units, players, creatures, game systems).
- [ ] Scripts (bosses, spell scripts, creature scripts).
- [x] Database (SAI, creatures, etc).
When accepting quest 13081 "The Will of the Naaru" from Highlord Tirion Fordring, Rhydian now:
- Walks halfway toward Tirion
- Says "Hail. I could not help but overhear your conversation. Please allow me to lend some assistance."
- Waits 5 seconds
- Casts spell 57676 (Portal to Shattrath) with cast animation
- Waits 18 seconds
- Walks back to her original position and orientation
- Resets to run mode
Issues Addressed:
- Closes https://github.com/azerothcore/azerothcore-wotlk/issues/23784
- Closes https://github.com/chromiecraft/chromiecraft/issues/8648
SOURCE:
The changes have been validated through:
- [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
- [ ] Sniffs (remember to share them with the open source community!)
- [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
- [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick).
Source: https://warcraft.wiki.gg/wiki/The_Will_of_the_Naaru
Tests Performed:
This PR has been:
- [x] Tested in-game by the author.
- [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
- [ ] This pull request requires further testing and may have edge cases to be tested.
How to Test the Changes:
- [x] This pull request can be tested by following the reproduction steps provided in the linked issue
- [ ] This pull request requires further testing.
.go creature id 31044(Tirion Fordring).mod phase 1.quest complete 13080(complete prerequisite quest)- Accept quest 13081 "The Will of the Naaru" from Tirion
- Observe Rhydian walk toward Tirion, speak, cast portal spell, then walk back
Known Issues and TODO List:
- None
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
Tested, Rhydian walks, talks, summons portal and walks back. Portal is working and teleports me directly to where I can complete the quest. Portal disappears after some time if I don't use it. All looking good.
In the "how to test" we need to .quest add 13080 before completing it.
One minor issue is that Rhydian starts talking 0.5-1s before stopping, which looks a bit odd... It's also different here, where she starts talking at the same time that she stops: https://www.youtube.com/watch?v=1njQsRaxCc4
Change the MOVE_TO_POS to set a PointID, then separate the actionlists into two. Then create a new event MOVEMENTINFORM, type 8 (Point) and PointID the same as the one set in the first step. This event fires the second part of the actionlist. This makes sure the line is spoken after reaching the point, not before.