refactor(Scripts/ZulAman): refactor Jan'alai

[elthehablo]

Changes Proposed:

This PR proposes changes to:

• [ ] Core (units, players, creatures, game systems).
• [x] Scripts (bosses, spell scripts, creature scripts).
• [ ] Database (SAI, creatures, etc).

Issues Addressed:

• Closes unreported issue (wrong spell for normal hatching)

SOURCE:

The changes have been validated through:

• [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [ ] Sniffs (remember to share them with the open source community!)
• [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found some stuff based on video evidence. this PR however is NOT yet based on sniffs and actual careful checking of videos. It's meant to mostly just refactor the script to use more modern scripts to make it easier to fix in the future

Tests Performed:

This PR has been:

• [x] Tested in-game by the author.
• [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
• [x] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
• [x] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go creature 89322
2. Go fight him, see if the hatchers seem to work correctly as well as if the bombs work correctly
3. Try to find some edge cases

Known Issues and TODO List:

• [ ] replace hard-coded shit with actual working spells
• [ ] remove hard-coded data being set and change to boss states

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.