azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Core/Events) Implement Fireworks Spectacular

Open sudlud opened this issue 9 months ago • 1 comments

Changes Proposed:

This PR proposes changes to:

  • [x] Core (units, players, creatures, game systems).
  • [x] Scripts (bosses, spell scripts, creature scripts).
  • [x] Database (SAI, creatures, etc).

Issues Addressed:

  • Closes #16677

SOURCE:

The changes have been validated through:

  • [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • [x] Sniffs (remember to share them with the open source community!)
  • [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Thanks @heyitsbench for sniffing all firework shows!

Tests Performed:

This PR has been:

  • [x] Tested in-game by the author.
  • [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

event runs for 18 hours .event start 72

firework shows start at the full hour and last for about 11-12 minutes at the locations there are kegs, tables, mugs and revelers revelers emote regularly revelers cheer at show end toasting goblets spawn at show end for 10 minutes

Booty Bay Bruisers are replaced by sleeping Drunken Bruisers

visit firework vendors Fizzlebang Booms .go c 12523 Ziggle Sparks .go c 12524 Wizbang Booms .go c 12525 Lillian Singh .go c 12526 Jaxxil Sparks .go c 12527 Kizzak Sparks .go c 12528

visit firework locations Stormwind .go c 420011 Thunder Bluff .go c 420024 Booty Bay .go c 420041 Teldrassil .go c 420122 Ironforge .go c 420141 Undercity .go c 420165 Orgrimmar .go c 420184 Shattrath (Scryer) .go c 420203 Shattrath (Aldor) .go c 420213 Exodar .go c 420221 Silvermoon .go c 420240

enjoy

Known Issues and TODO List:

  • [ ] reveler gossip texts missing, they're showing Lunar (?) gossips right now, as they're also present during that event
  • [ ] reveler orientations need to be updated (manually) - sniffs CO seem to have shown orientations right in the middle of some RP most of the time, could be grepped from sniff reset-orientation-home-messages maybe
  • [ ] reveler RP might not be final - they seem to orient themselfes to the firework and back sometimes, also the emotes during could be added to the show script (maybe) to get it right
  • [ ] Thunder Bluff Reveler spawns might need a check - they seem to be a bit much, they probably should have much less spawns and waypoint movement

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

sudlud avatar May 05 '24 19:05 sudlud

damn

Kitzunu avatar May 06 '24 19:05 Kitzunu

Awesome work @sudlud . I'll give this a test and a review promptly

elthehablo avatar May 11 '24 12:05 elthehablo

Works well, nice work

elthehablo avatar May 11 '24 20:05 elthehablo