fix(Scripts/Spell) Rogue glyph of backstab (port from TrinityCore)

[skelUA]

Changes Proposed:

This PR proposes changes to:

• [ ] Core (units, players, creatures, game systems).
• [ ] Scripts (bosses, spell scripts, creature scripts).
• [ ] Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [ ] Sniffs (remember to share them with the open source community!)
• [ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [ ] Tested in-game by the author.
• [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
• [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

Current Behaviour Currently Glyph of Backstab makes the Rupture doesn't deal damage last 6 seconds before DOT debuff end. Expected Blizzlike Behaviour Glyph upgrades Backstab to prolongs DOT debuff of Rupture per 2 seconds each time Backstab used (up to 6 seconds). Steps to reproduce the problem:

0. Don't use poisons on your weapons (it simplifies the test);
1. Use Glyph of Backstab;
2. Stack 5 CP on Training Dummy;
3. Spend 5 CP on Rupture ability;
4. Use Backstab 3 times;
5. Write /stopattack to game chat and observe the DOT ticks of Rupture (should deal damage every 2 seconds);
6. After Rupture debuff reach 6 seconds left it will not deal damage anymore, but should deal damage 3 times.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

This fix made with @tagrim

[pangolp]

Greetings. Thanks for the input. If you would be so kind as to please complete the pull request with the necessary data to be able to carry out the tests, the people who do it will be able to know what they have to test and the results they have to obtain from said tests. Thank you so much.

[skelUA]

Greetings. Thanks for the input. If you would be so kind as to please complete the pull request with the necessary data to be able to carry out the tests, the people who do it will be able to know what they have to test and the results they have to obtain from said tests. Thank you so much.

add test case

[Nyeriah]

Please use the new spell registration method (you can check examples in that file)

[avarishd]

Status?

https://github.com/chromiecraft/chromiecraft/issues/6520

[Vtkachenko-Informa]

Need more time to rewrite