fix(DB/Gossip_Menu_Option_Locale): fix german umlauts

[V-Cyberpunk]

Changes Proposed:

This PR proposes changes to:

• [ ] Core (units, players, creatures, game systems).
• [ ] Scripts (bosses, spell scripts, creature scripts).
• [x] Database (SAI, creatures, etc).

Issues Addressed:

• Closes https://github.com/azerothcore/azerothcore-wotlk/issues/18773

SOURCE:

The changes have been validated through:

• [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [ ] Sniffs (remember to share them with the open source community!)
• [ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [x] Tested in-game by the author.
• [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
• [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
• [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. e.g. go to learning dual spec.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[sudlud]

Missing new line at end of file

[sudlud]

Thanks for the PR!

Do you want to check if other _locale tables might also be affected maybe? So we could fix them in another PR if necessary

[V-Cyberpunk]

i will look into that :)

[V-Cyberpunk]

i think clicking closed was wrong....

[V-Cyberpunk]

other locales are fine!

[V-Cyberpunk]

how is the "ready to be review" label be added? or is that automatic?

[sudlud]

Thanks for the fix :)

[sudlud]

i actually dumped the DB table before and after PR and looked at the diff and couldn't see any unintended or incorrect changes.

Edit: I did not check in-game with a german client if it shows correctly

[pangolp]

Asked out of ignorance, but shouldn't we have to specify the language here in the query? Couldn't this affect another language?

UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ä','ä') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ü','ü') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ö','ö') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ä','ä') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ü','ü') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ö','ö') WHERE `Locale`='deDE';

I don't have a client in Germany either to really be able to do the tests. I only have one client in English and Spanish. But perhaps if the owner of the pull request can provide us with photos of the tests before and after applying the pull request, that will surely help us.

[pangolp]

Sorry, there was already an image inside the body of the pull request. He hadn't seen her. If you could upload one with the bug, that would be great, although it wouldn't be necessary either. It is simply because in my case, I do not have a client to be able to do the tests in that language.

What I would like to know, as I mentioned in the previous comment, if not, it would be better to specify the Locale, as I mentioned previously...

[pangolp]

Before applying the fix

After applying the fix

I did the tests with this script. If you need help, I can make a commit on that topic. In case you can't. But since the title says German, I think it would be interesting to add this modification, to specify the language.

UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ä','ä') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ü','ü') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `OptionText`=REPLACE(`OptionText`,'ö','ö') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ä','ä') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ü','ü') WHERE `Locale`='deDE';
UPDATE `gossip_menu_option_locale` SET `BoxText`=REPLACE(`BoxText`,'ö','ö') WHERE `Locale`='deDE';

[sudlud]

I agree with @pangolp that adding that additional "safety net" could not hurt.

[pangolp]

Let's wait if he passes the tests...