azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Scripts/Zones/Creature): Updating Torturer Lecraft

Open Knindzagxg opened this issue 10 months ago • 1 comments

Changes Proposed:

This PR proposes changes to:

  • [x] Core (units, players, creatures, game systems).
  • [x] Scripts (bosses, spell scripts, creature scripts).

Issues Addressed:

  • After some time creature will bug itself and will spam Kidney Shot on player no matter what.

SOURCE:

The changes have been validated through:

  • [x] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

Tests Performed:

This PR has been:

  • [x] Tested in-game by the author.
  • [x] Tested in-game by other community members/someone else other than the author/has been live on production servers.

How to Test the Changes:

  • [x] This pull request can be tested by following the reproduction steps provided in the linked issue
  1. .quest add 12252 (Add Quest to yourself)
  2. .go cre 102544 (Teleport to creature)
  3. Use quest item and watch hes AI.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Knindzagxg avatar Apr 14 '24 16:04 Knindzagxg

Could you restructure the script to use the more modern form of a ScriptedAI struct?

See: https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/scripts/Outland/boss_doomwalker.cpp as an example

elthehablo avatar May 12 '24 10:05 elthehablo

Its just a part of the script and whole zone, not a single one.

Knindzagxg avatar Jul 28 '24 10:07 Knindzagxg