azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(DB/Creature)Added paths for patrolling mobs in the Scarlet Abbey chapel area

Open fangshun2004 opened this issue 10 months ago • 5 comments

Changes Proposed:

This PR proposes changes to:

  • [ ] Core (units, players, creatures, game systems).
  • [ ] Scripts (bosses, spell scripts, creature scripts).
  • [x] Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • [x] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • [x] Sniffs (remember to share them with the open source community!)
  • [] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [x] Tested in-game by the author.
  • [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .go c 39959
  2. go c 39998
  3. go c 39967
  4. go c 39978
  5. go c 39980
  6. go c 40015
  7. go c 40019
  8. go c 40008
  9. go c 40034

无标题

Known Issues and TODO List:

  • [ ]Patrol mobs and some guid mobs randomly spawn different entry mobs.
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

fangshun2004 avatar Apr 13 '24 14:04 fangshun2004

These paths are better with waypoint_data??

fangshun2004 avatar Apr 13 '24 14:04 fangshun2004

These paths are better with waypoint_data??

Waypoints is the correct table using smart scripts to trigger movement. So yes this is correct as it is now

elthehablo avatar Apr 13 '24 15:04 elthehablo

Make title more descriptive/fit our PR standards please

elthehablo avatar Apr 13 '24 15:04 elthehablo

What did the conditions do?

elthehablo avatar Apr 15 '24 12:04 elthehablo

I will check this again tonight

elthehablo avatar Apr 15 '24 12:04 elthehablo