azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix (Core/Scripting) SMART_EVENT_NEAR_PLAYERS

Open skelUA opened this issue 1 year ago • 5 comments

Changes Proposed:

This PR proposes changes to:

  • [x] Core (units, players, creatures, game systems).
  • [x] Scripts (bosses, spell scripts, creature scripts).
  • [ ] Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • [ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • [ ] Sniffs (remember to share them with the open source community!)
  • [ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [x] Tested in-game by the author.
  • [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

skelUA avatar Nov 30 '23 08:11 skelUA

@Kitzunu plz review

skelUA avatar Jan 18 '24 08:01 skelUA

My review still stands. You have not addressed any of the concerns I lifted. You can't just simply resolve a review without doing anything and expect me to forget it lol.

Kitzunu avatar Jan 20 '24 13:01 Kitzunu

My review still stands. You have not addressed any of the concerns I lifted. You can't just simply resolve a review without doing anything and expect me to forget it lol. @Kitzunu But i answered on all your questions. Or what i do wrong?

image

skelUA avatar Jan 21 '24 08:01 skelUA

the comment is set as "pending" you need to press these buttons image

Kitzunu avatar Jan 21 '24 11:01 Kitzunu

What status is this pull request in?

pangolp avatar Feb 13 '24 22:02 pangolp

@Kitzunu So may you review now or i need to do something else ?

skelUA avatar Mar 03 '24 15:03 skelUA

Can you please add information to the PR description

  • what was wrong before
  • what is fixed now with this PR
  • steps to reproduce the problem before PR
  • steps to reproduce the fix after applying the PR

Thanks!

sudlud avatar Mar 08 '24 15:03 sudlud