fix(Scripts/IcecrownCitadel): Make Blood-Queen Lana'thel bite tanks as well

[0x7FFF]

Make Blood-Queen Lana'thel bite tanks by removing useless checks.

Changes Proposed:

This PR proposes changes to:

• [ ] Core (units, players, creatures, game systems).
• [X] Scripts (bosses, spell scripts, creature scripts).
• [ ] Database (SAI, creatures, etc).

Issues Addressed:

• None in the issues tab

SOURCE:

As stated in various sources below: https://www.reddit.com/r/wow/comments/2kgsbd/how_to_solo_blood_queen_lanathel_in_icc/ https://www.mmo-champion.com/threads/1123873-Solo-Blood-Queen-Lana-thel https://www.wowhead.com/npc=37955/blood-queen-lanathel#comments;mode:n10 Blood-Queen Lana'thel should bite tanks.

The changes have been validated through:

• [X] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [ ] Sniffs (remember to share them with the open source community!)
• [ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• [X] Tested in-game by the author.
• [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
• [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• [X] This pull request can be tested by following the reproduction steps provided in the linked issue
• [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

I am unsure of this implementation. from what I can gather she should only bite a tank if there is no other to bite. I may be wrong though

[qwe900]

As i now from the past, she just does notbite pople with bloodmirror, but tank could be biten

[Kitzunu]

That makes sense

[ghost]

I can confirm this behavior from experience. PR seems fine.

[TheSCREWEDSoftware]

What's the current state of this PR? @0x7FFF

[chaosua]

https://wowwiki-archive.fandom.com/wiki/Blood-Queen_Lana%27thel_(tactics) Old guide says "15 seconds after the start of the encounter Blood-Queen Lana'thel bites the highest threat player which is not tanking, dealing the Vampire debuff"

[qwe900]

Top on threatlist which is not effected by bloodmirror. Is the key. U can get be biten as soloing the boss

[Kitzunu]

instead of commenting on a closed PR you can comment on the open one which rewrites the target selection