fix(Scripts/ScarletMonastery): improvement ScarletMonastery

[fangshun2004]

Changes Proposed:

1. Go to the pull request #15218 from @feltwitch to see the detailed changes I gave with the sniffing data given by @heyitsbench based on that pull request Reworked triggering the Ember Bringer event.
2. The door should open after the event is triggered, and Mograini should be able to receive a welcome dialogue.
3. NPCs inside the church. All Friendly, Removed Whiteman

4 . Added the emote（salute） of Whitemane's creature after resurrecting Mograine（growl）. 5. After resurrecting Mograine, Whitemayne dies, the player quits the fight or dies, and Mograine does not respawn Pick up Mograine's items without a shot Out of combat should be respawning rather than waiting for the mob to move back to the spawn point 6. Whitemane's HOLY_SMITE spells should be cast at ranged (not moving) whenever possible, and will only attempt to move to melee range if the spell is unusable (behind a building, etc.). 7. Whitemane has less than 50% HP and is released DEEP_SLEEP after the spell should be moved to Mograine's side before using Resurrection (if the player does not have a DEEP_SLEEP debuff after moving to Mograine, the resurrection will be released immediately, and if there is a debuff, it will wait for 5 seconds before it is released) 8. When Mograine has dot damage and triggers the first death, the dot damage number can still appear on Mograine, and does not remove all Aura

This PR proposes changes to:

• [x] Scripts (bosses, spell scripts, creature scripts).
• [x] Database (SAI, creatures, etc).

Issues Addressed:

• Closes https://github.com/azerothcore/azerothcore-wotlk/issues/14478

SOURCE:

The changes have been validated through:

• [x] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• [x] Sniffs (remember to share them with the open source community!)
• [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• [x] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

https://github.com/azerothcore/azerothcore-wotlk/pull/15218

Tests Performed:

This PR has been:

• [x] Tested in-game by the author.

How to Test the Changes:

• [x] This pull request can be tested by following the reproduction steps provided in the linked issue

Tests Ashbringer

1. .additem 22691.
2. .level 60 or .character level 60.
3. Armament weapon ID 22691 .additem 22691.
4. .instance unbind all.
5. .tele smcath.
6. The doors of the church should be opened.
7. Unloading weapon ID 22691 after Ashbringer event All creatures in the dungeon should be friendly (including in churches)

Test combat

1. .level 80 or .character level 80.
2. It is recommended to use a Warlock or Priest to test the battle when changing weapons.
3. Use dot spells on Mograine as much as possible, such as Doomsday Curse, Corrosion, etc. After Mograine dies for the first time and falls to the ground, you can still see the damage on Mograine on the ground.
4. Whitemane exits from behind the gate and moves to Mograine's side, and does not enter the battle (at player level 80, enters the battle at low level), at which point Whitemane will always stay outside the gate if .gm on is used, and will not return to the spawn point.
5. Whitemane should always cast HOLY_SMITE spell in place, and after taking a detour behind a pillar, Whitemane will attempt to move to melee range to attack the player
6. After Whitemane first enters the fight Pull him away from Mograine's corpse (the farther away the better) and reduce his HP to less than 50% Trigger the Resurrection Mograine event Whitemane hypnotizes the player and starts moving next to Mograine's corpse (now just stays in place and uses the resurrection spell until Mograine is revived) Until Mograine resurrects, his HP will only drop to 1 at most, and he will not be able to kill him
7. Whitemane will make an emote after resurrecting Mograine

Known Issues and TODO List:

• [x] Adds missing behaviors in the resurrection event when Mograine and Whitemane fight
• [x] Modified Whitemane act of releasing spells -［］Move C++ scripts to SmartScript

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[fangshun2004]

I really can't find where there are extra spaces 😒😒😒😒😒😒

[elthehablo]

Please fix title to conform to our standards fix(Scripts/ScarletMonastery): blablabla improvement Ashbringer event

[elthehablo]

Also make sure to revolve no longer relevant review comments. Makes it easier to see what still needs fixing and what doesn't :). Nice work on this so far!

[Kitzunu]

Anyone want to test this? :DDDD @azerothcore/testers @heyitsbench <3 o.o

[fangshun2004]

Redone Battles Need to be re-examined, sorry everyone

[laowoji]

Is this in the test? Can anyone test and write a test report？

[fangshun2004]

This pull request is complete. I'm not sure if it's in the test. But you can test to give what needs to be modified.

获取Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: laowoji @.> Sent: Friday, January 19, 2024 9:25:29 AM To: azerothcore/azerothcore-wotlk @.> Cc: daobashun @.>; Author @.> Subject: Re: [azerothcore/azerothcore-wotlk] fix(Scripts/ScarletMonastery): improvement ScarletMonastery (PR #17558)

Is this in the test? Can anyone test and write a test report？

― Reply to this email directly, view it on GitHubhttps://github.com/azerothcore/azerothcore-wotlk/pull/17558#issuecomment-1899486265, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALXKHRZZHKZVWCTHQRKSCD3YPHDQTAVCNFSM6AAAAAA6KS22BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQ4DMMRWGU. You are receiving this because you authored the thread.Message ID: @.***>

[sudlud]

In the meantime there has been a PR merged (#18082) which addresses the issue with Whitemane dying out of combat (point 3. on this PR description).

Do you think this PR needs an update because of this?

[fangshun2004]

It doesn't need to be updated, it's been fixed inside this rp

获取Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: sudlud @.> Sent: Sunday, March 10, 2024 8:19:34 PM To: azerothcore/azerothcore-wotlk @.> Cc: daobashun @.>; Author @.> Subject: Re: [azerothcore/azerothcore-wotlk] fix(Scripts/ScarletMonastery): improvement ScarletMonastery (PR #17558)

In the meantime there has been a PR merged (#18082https://github.com/azerothcore/azerothcore-wotlk/pull/18082) which addresses the issue with Whitemane dying out of combat (point 3. on this PR description).

Do you think this PR needs an update because of this?

― Reply to this email directly, view it on GitHubhttps://github.com/azerothcore/azerothcore-wotlk/pull/17558#issuecomment-1987207919, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALXKHRYJSD2QPZX4ZAVZ74TYXRFVNAVCNFSM6AAAAAA6KS22BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGIYDOOJRHE. You are receiving this because you authored the thread.Message ID: @.***>

[fangshun2004]

In the meantime there has been a PR merged (#18082) which addresses the issue with Whitemane dying out of combat (point 3. on this PR description).

Do you think this PR needs an update because of this?

＃1802 was fixed to be killed before Whitemane's resurrected Mograine. This one. The RP test is that after Mograine was resurrected, Whitemane's was killed. The player is out of battle or the player dies. Does not respawn Mograine.

[pangolp]

Without a doubt, it seems like a great contribution. I'll try to try it later. If I don't understand something, I'll be asking.

[sudlud]

Why did you close all your PRs?

[fangshun2004]

？？I'm cleaning up a branch that has been merged. Too many branches in TortoiseGit i can't see which ones have been merged

获取Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: sudlud @.> Sent: Monday, April 1, 2024 9:33:09 PM To: azerothcore/azerothcore-wotlk @.> Cc: daobashun @.>; State change @.> Subject: Re: [azerothcore/azerothcore-wotlk] fix(Scripts/ScarletMonastery): improvement ScarletMonastery (PR #17558)

Why did you close all your PRs?

― Reply to this email directly, view it on GitHubhttps://github.com/azerothcore/azerothcore-wotlk/pull/17558#issuecomment-2029766145, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALXKHRYKQYU7NXSXVNUCEU3Y3FOZLAVCNFSM6AAAAAA6KS22BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZG43DMMJUGU. You are receiving this because you modified the open/close state.Message ID: @.***>

[sudlud]

Ah ok because you deleted 4 branches of PRs that were not merged yet