fix(DB/SAI): Shay Leafrunner

[The-GhostRider]

Changes Proposed:

• Fix NPC: Shay Leafrunner

Issues Addressed:

• Closes https://github.com/chromiecraft/chromiecraft/issues/2186
• Closes https://github.com/azerothcore/azerothcore-wotlk/issues/16453

SOURCE:

Tests Performed:

• Tested in game and working
• Tested on Windows 10 (64)
• Video Before my Fix with AI in C++: AI C++ npc_shay_leafrunner bugs
• Video Test after my SAI Fix: Quest - Wandering Shay

[Note]:

Generally my PRs don't need to be reviewed as I always attach Videos that demonstrate how they work, so once my PR pass the Bot reviews, just watch my Videos, after which they can be merged. Anyway, if you wish test my work in any case, feel free to do so, I do so just to save you time and optimize "Bureaucracy" (let's say)..

How to Test the Changes:

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

in this case your title should be fix(DB/Creature)

We use the "base" class, such as Creature/Instance/GameObject/Spell etc. in the second part, never table names 👌

[The-GhostRider]

in this case your title should be fix(DB/Creature)

We use the "base" class, such as Creature/Instance/GameObject/Spell etc. in the second part, never table names 👌

I will try to follow your instructions, in case I will make another mistake, I apologize in advance! 😅

[Kitzunu]

Actually my bad, I was wrong. I have learned that when a PR only touches smart scripts and nothing else creature related it should be DB/SAI

Sorry for that 😅

[FrancescoBorzi]

@Gultask @Kitzunu what's the status of this PR? needs more test, changes or what? please don't forget to apply the workflow labels when reviewing PRs, so we avoid to forget PRs behind

[elthehablo]

@Gultask @Kitzunu what's the status of this PR? needs more test, changes or what? please don't forget to apply the workflow labels when reviewing PRs, so we avoid to forget PRs behind

I will test it

[elthehablo]

Tested with no issues found

[elthehablo]

I cannot review, buddy. I'm not a maintainer. Well, I can. But it does nothing

[heyitsbench]

I cannot review, buddy. [...] Well, I can. But it does nothing

Bask in your valuable opinion, just cause you don't have write access doesn't mean it's not appreciated. 😀