azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

(DB): Name columns are accent-insensitive

Open r-o-b-o-t-o opened this issue 1 year ago • 4 comments

Current Behaviour

All tables and columns are created with utf8mb4_unicode_ci, which is accent insensitive. This means, among other things, that we cannot create characters that have the same name but with accents. For example, if there is a character named Aa, creating a character named Äâ will be impossible even though it does not exist yet.

Note: on MySQL, this could be fixed by using utf8mb4_0900_as_ci. For instance:

ALTER TABLE `characters` MODIFY `name` varchar(12) COLLATE utf8mb4_0900_as_ci NOT NULL;

However, this is not available on MariaDB and I am not aware of a character set that accomplishes this and exists on both MySQL and MariaDB ☹️

https://github.com/azerothcore/azerothcore-wotlk/assets/24357633/107bf15c-4f85-466e-906c-593e2b7fec9f

Expected Blizzlike Behaviour

I believe players should be able to create characters with the same name as another but with accented letters.

Source

No response

Steps to reproduce the problem

See video above

Extra Notes

No response

AC rev. hash/commit

42a1650d3146e025d996ce5b9b5dfbd9bd8fbe88

Operating system

Windows 11 x64, MySQL v8.0.31

Custom changes or Modules

No response

r-o-b-o-t-o avatar May 18 '23 13:05 r-o-b-o-t-o

Fuck maria

Kitzunu avatar May 18 '23 14:05 Kitzunu

That's why Llègöläss was taken already

Tereneckla avatar May 18 '23 14:05 Tereneckla

This is a relatively new issue. You can see in the armory that such characters do exist: image

And I was able to create Nícci on April 16th, despite Nicci already existing. Then when I deleted and attempted to re-create her on May 12th, it no longer worked.

Vyperhand avatar May 18 '23 15:05 Vyperhand

This is a relatively new issue. You can see in the armory that such characters do exist:

My guess is it's related to https://github.com/azerothcore/azerothcore-wotlk/pull/15433 We probably had an accent insensitive charset on Chromie before, which was replaced by that PR probably

r-o-b-o-t-o avatar May 18 '23 15:05 r-o-b-o-t-o

https://github.com/TrinityCore/TrinityCore/commit/fb388298a0bf76402a6f1de35bdfcb33223d51bb

Kitzunu avatar May 19 '23 18:05 Kitzunu

utf8mb4_bin is supported by Maria too

Kitzunu avatar May 19 '23 18:05 Kitzunu

https://github.com/azerothcore/azerothcore-wotlk/pull/16344

Kitzunu avatar May 21 '23 20:05 Kitzunu