azerothcore-wotlk
azerothcore-wotlk copied to clipboard
fix(Scripts/Karazhan): Opera Wizard of Oz fight correct start timers for combat as well fixing restart of the event
Changes Proposed:
- change timers according to evidence gathered from archive footage
- despawn corpses immediately as well, as well as despawning at evade (because they do persist atm)
Issues Addressed:
-
Closes https://github.com/azerothcore/azerothcore-wotlk/issues/16283
-
Closes https://github.com/azerothcore/azerothcore-wotlk/issues/16304
-
Closes https://github.com/chromiecraft/chromiecraft/issues/5621
-
Closes https://github.com/chromiecraft/chromiecraft/issues/5620
SOURCE:
Used the following videos for the timers:
Tests Performed:
- tested by myself. seems to wor
How to Test the Changes:
Known Issues and TODO List:
- [x] allow Oz fight to reset even when Crone is not summoned yet
- [ ] wowhead and other strategy guides speak of an enrage that happens when Tito is killed and Dorothee still alive. this is easy to implement, but we need sniffs for this because a regular enrage (which they link) would only increase melee damage and since Dorothee only casts spells this does not seem likely
- [ ] get better timers using sniffs as well as the appropriate respawns and such
- [ ] perhaps handle despawning in a different way (either using a scheduler or in another way) NEEDS SNIFFS
- [ ] modernise with scheduler instead of events -> I want to do that in another PR
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.