[TBC Karazhan] Nightbane Fireball Barrage has the wrong conditions to be cast

[elthehablo]

Originally reported on CC at: https://github.com/chromiecraft/chromiecraft/issues/5608 By: NinesCC

What client do you play on?

enUS

Faction

Both

Content Phase:

70

Current Behaviour

Nightbane randomly casts Fireball Barrage even if everyone is on range. It seems to cast it once every Air Phase

Edited short version https://youtu.be/wclvfzaeAFw

Full PTR run footage https://youtu.be/6Gu8jrJ_TrU?t=3899

also see current code implementation:

if (FireballBarrageTimer <= diff)
                {
                    if (Unit* target = SelectTarget(SelectTargetMethod::MinDistance, 0))
                        DoCast(target, SPELL_FIREBALL_BARRAGE);
                    FireballBarrageTimer = 20000;
                }

Expected Blizzlike Behaviour

Fireball Barrage should only be triggered when a raid member is too far away from Nightbane, it should continue casting it 1 per second until everyone is in range.

Source

TBC Classic https://youtu.be/mVb6CCxBMA8?t=1600 Some of the casters die due to being too far away from Nightbane and get hit by Fireball Barrage

https://wowpedia.fandom.com/wiki/Nightbane_(tactics)

Fireball Barrage: If any member of the raid is too far away from Nightbane while he is in flight, he pelts the raid with fireballs, each doing about 3,000-3,500 damage, casting 1 per second until all members are within range. This ability exists to prevent exploiting and is not something you will notice if you do things correctly.

Steps to reproduce the problem

1. .tele kara
2. Go to Nightbane (Faster through the back door).
3. Damage Nightbane to 75% to enter Air Phase
4. Watch the spells he casts, you will see the Fireball Barrage randomly be casted.

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/8224a90a99cc40ff9a7a9a3ab4d7aecc40aacd3d

Operating system

Ubuntu 20.04

Modules

• mod-ah-bot
• mod-bg-item-reward
• mod-BreakingNewsOverride
• mod-cfbg
• mod-chat-transmitter
• mod-cta-switch
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-carbon-copy
• lua-event-scripts
• lua-exchange-npc
• lua-level-up-reward
• lua-recruit-a-friend
• lua-send-and-bind
• lua-temp-announcements
• lua-zonecheck

Customizations

None

Server

ChromieCraft