azerothcore-wotlk fix(DB:Karazhan): fix mechanical immunities of Ghostly Steward as well as fixing/improving Frenzy

fix(DB:Karazhan): fix mechanical immunities of Ghostly Steward as well as fixing/improving Frenzy

Open elthehablo opened this issue 1 year ago • 1 comments

Changes Proposed:

change mech immune masks to make Ghostly Stewards immune to most CC and taunts
change SAI so frenzy events fire correctly at 50% instead of between 0% and 30%

Issues Addressed:

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/16212
Closes https://github.com/azerothcore/azerothcore-wotlk/issues/16211

CC:

Closes https://github.com/chromiecraft/chromiecraft/issues/5578
Closes https://github.com/chromiecraft/chromiecraft/issues/5577

SOURCE:

Tests Performed:

Tests needed, especially to check threat drop

How to Test the Changes:

.npc add 16414

Known Issues and TODO List:

[x] fixes mechanical immunities by taking same values as TC
[x] Frenzy now fires at 50% with the creature emoting as well as wiping threat
[ ] more research has to be done regarding the lines being said with what events/abilities

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.