azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Scripts/Outland): add missing C++ code and remove SAI scripts from Tavarok and Darkweaver Syth

Open elthehablo opened this issue 1 year ago • 0 comments

Changes Proposed:

  • [x] change SAI bosses Tavarok and Darkweaver Syth into C++ code, making sure all bosses are coded properly
  • [x] made sure the right spell is now being used for the heroic version of arcane shock (was previously using the normal version (see old SAI))

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

  1. run the instances. compare old behaviour to new behaviour. should be the same or at least very similar

Known Issues and TODO List:

  • [ ] timers might be incorrect (need proper sniffing)
  • [ ] the internet is a bit divided on the hp percentages at which Darkweaver Syth casts the summons. Right now it is 90, 50, 10 but I have also heard 90, 55, 15 and others. Also needs sniffs/testing on retail

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

elthehablo avatar May 05 '23 11:05 elthehablo