azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Scripts/ShatteredHalls): fix some timers/mechanics of Grand Warlock Nethekurse

Open elthehablo opened this issue 1 year ago • 0 comments

Note: this is likely my last commit to this (other than cleaning codestyle. So it either has to be merged and then improved on or closed. I am sorry, but this is my current limit in AC scripting knowledge lol.

Changes Proposed:

  • timers changed according to https://github.com/azerothcore/azerothcore-wotlk/issues/16070
  • also changed mechanics according to same issue

Issues Addressed:

  • Progress https://github.com/azerothcore/azerothcore-wotlk/issues/16070

SOURCE:

see issue

Tests Performed:

  • testing done by me. events work
  • RP is still broken and is basically unaltered

How to Test the Changes:

Known Issues and TODO List:

  • [x] RP still missing
  • [ ] RP and movement is wonky and needs to be fixed (specifically him flying at some locations)
  • [x] Make less commits next time
  • [ ] Some lines fire multiple times
  • [ ] Peon engaged line fires when boss casts Death Coil (probably have to implement a check for the unit that is attacking)
  • [x] Fight is doable and timers for fight are correct

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

elthehablo avatar May 03 '23 09:05 elthehablo