azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Scripts/Underbog): modernise boss scripts

Open elthehablo opened this issue 1 year ago • 0 comments

Changes Proposed:

  • use taskscheduler instead of events
  • remove heroic mechanic on black stalker that swarms the group with adds

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

  • [ ] timers need to be looked at extensively
  • [ ] muselek needs cpp script, but: https://github.com/azerothcore/azerothcore-wotlk/pull/14724

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

elthehablo avatar May 01 '23 09:05 elthehablo