azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Scripts/Temple of AhnQiraj): AhnQiraj critters should enter comba…

Open UltraNix opened this issue 2 years ago • 5 comments

…t with nearby attacked players.

Fixes #12909

Issues Addressed:

  • Closes #12909

Tests Performed:

  • Tested ingame.

How to Test the Changes:

.go c id 15316 or .go c id 15317 pull a nearby trash mob, see if the critters react.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

UltraNix avatar Sep 10 '22 08:09 UltraNix

It works but I was going to change their SAI to add missing spells :c Could you add those in this PR? Or should I open another issue?

They:

  • [ ] Cast 6016 on victim within range 0-5y, repeating every 5000-9000ms.
  • [ ] Cast 26050 on victim, initial 5000-9000ms, repeats every 6000-12000ms.
  • [ ] Despawn after 5000ms on death.
  • [X] Change faction on reset. (To fix an issue in the Twin Emperors fight)
(15317, 0, 0, 0, 9, 0, 100, 0, 0, 5, 5000, 9000, 0, 11, 6016, 32, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 'Qiraji Scorpion - Within 0-5 Range - Cast \'Pierce Armor\''),
(15317, 0, 1, 0, 0, 0, 100, 0, 5000, 9000, 6000, 12000, 0, 11, 26050, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 'Qiraji Scorpion - In Combat - Cast \'Acid Spit\''),
(15317, 0, 2, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 41, 5000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Qiraji Scorpion - On Just Died - Despawn In 5000 ms'),
(15317, 0, 3, 0, 25, 0, 100, 0, 0, 0, 0, 0, 0, 2, 311, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Qiraji Scorpion - On Reset - Set Faction 311');

I'll update my PR right now to not conflict with this one.

Gultask avatar Sep 11 '22 02:09 Gultask

@Gultask I will add it here.

UltraNix avatar Sep 11 '22 05:09 UltraNix

@Gultask Done.

UltraNix avatar Sep 11 '22 07:09 UltraNix

It works 👍 Thank you ^^

Gultask avatar Sep 11 '22 12:09 Gultask

Conflicts

Nefertumm avatar Sep 17 '22 20:09 Nefertumm

@Nefertumm @acidmanifesto Done.

UltraNix avatar Sep 24 '22 06:09 UltraNix