azerothcore-wotlk
azerothcore-wotlk copied to clipboard
fix(CORE/Naxxramas): Portals and Teleports
This fixes overlapping portals inside and outside Naxxramas. Their rotation is also corrected (from CCW to CW). The post-boss Naxxramas portals now teleport to the blue hub portal and it activates only when all wings are cleared. This requirement can be bypassed with the orbs, which are now correctly casting their respective sapphiron entry/exit spells in addition to having the correct position.
Changes Proposed:
- Remove duplicate green portal objects outside Naxxramas in Dragonblight
- Remove duplicate green portal object inside Naxxramas
- Change animation of portals outside Naxx from CCW to CW
- Fix post-boss and Sapphiron entry/exit teleport spells to the correct positions
- Fix position of the Orbs of Naxxramas
- Add allwingscleared requirement to the naxx hub portal
- Fix position of the hub portal teleport to the center of the blue portal
Useless purple portal object inside and outside
10man portals are spinning CCW. 25man portals have duplicates and spinning CCW.
https://user-images.githubusercontent.com/74299960/184081871-72b5fa3f-de66-49fb-8f39-efc90c9a182a.mp4
Teleport position to Sapph is too far forward, orb in the middle teleports to the ground, orb in the back teleports to where the char is standing.
Issues Addressed:
SOURCE:
00:00 Entrance Portal to Naxx25 shows 4 orbs CW 11:03 Naxxramas Portal to hub position, 25man portal inside Naxx, Position of Orb of Naxxramas (TP to Sapph) 31:40 TP Location to Sapphiron
https://www.youtube.com/watch?v=jIwKLtcbdq0
AutoTP to Sapph is not showing in this vid, but is present on beta https://youtu.be/flM7uylhUGU?t=5487 1:31:27
Tests Performed:
https://user-images.githubusercontent.com/74299960/184083357-41eba12b-7954-48e7-bb43-06ec944a0231.mp4
How to Test the Changes:
25man difficulty
/script SetRaidDifficulty(2)
10man difficulty
/script SetRaidDifficulty(1)
Teleport outside Naxxramas in Dragonblight
.tele Naxxramas
- With
.gm fly on
in Dragonblight go.go xyz 3668 -1262 310
and check if purple portal is gone - Watch green portals outside/inside with 10m/25m difficulty. See they're spinning CW and there are no overlapping portals
- Inside Naxx25 see that there are no overlapping green portals inside
- Inside Naxx10/25 see that the portal floating above the hub is gone
- Inside Naxx10/25 see there is an orb at the hub that allows teleport to Sapphiron
- Inside Naxx10/25 see there is an orb at the back of Sapp room that teleports down
- Inside Naxx10/25 check that boss portals TP to the middle of blue hub (spellID: 28444)
- Go to the blue portal trigger 4156
.debug areatrigger
and trigger without wings cleared and once with (Thaddius, Maexxna, Horsemen, Loatheb should be dead), see if portal activates
You can check TP spells individually with
Name | cmd | where |
---|---|---|
Exit Spell | .learn 72613 |
next to portal |
DK Portal | .learn 28444 |
to blue portal facing north |
Entry | .learn 72617 |
to sapphiron, middle of blue room and facing sapphiron |
Known Issues and TODO List:
- [ ] Portals inside Naxx25 still shows 2 orbs floating as they're part of the map and not game objects.
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
First of all. Sorry for the very delayed testing xd Second, thanks a lot for all the work you've put in this!
It works as described and is much more similar to retail now 👍
Thank you for the PR