azerothcore-wotlk
azerothcore-wotlk copied to clipboard
Published
20 hours ago •
azerothcore
azerothcore
fix(DB/Gossip): Fix gossip for anachronos
Changes Proposed:
- Remove duplicate and wrong gossip (there a second gossip with the good conditions).
Issues Addressed:
- Closes https://github.com/azerothcore/azerothcore-wotlk/issues/12658
SOURCE:
Tests Performed:
- Tested
How to Test the Changes:
- Speak with Anachronos ( .go c id 15192 and need to be neutral at least -> .modify reputation 910 3000)
- He should not show the gossip "I'm ready.... the Scepter of Shifting Sands".
- .q add 8742 ->Always not show the gossip
- .q complete 8742 and .q reward 8742 -> Should show the gossip
- If you click on it, you will recive the scepter
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
