azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(core/quest): improved egg freezing

Open grimgravy opened this issue 2 years ago • 3 comments

Changes Proposed:

  • Fix: Freeze a nearby Rookery Egg
  • improved PR #9039

173934-egg-freezing

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • was performed windows 7 64bits. Not a single error was found and it is Functional

How to Test the Changes:

  1. add the quest with command:
  2. quest add 4734

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

grimgravy avatar Jul 28 '22 23:07 grimgravy

Can you say us what was the initial issue for testing ?

ghost avatar Jul 31 '22 08:07 ghost

It fails after clicking to disarm trap (egg), but it also doesn't freeze. Sometimes you can disarm trap

grimgravy avatar Jul 31 '22 10:07 grimgravy

Tested and work fine. Thanks for your PR :)

ghost avatar Aug 07 '22 09:08 ghost