azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(DB/gossip_menu_option_locale): Populate missing entries from broadcast text (frFR)

Open ZhengPeiRu21 opened this issue 2 years ago • 1 comments

Changes Proposed:

  • Use existing broadcast_text_locale data to populate missing gossip_menu_option_locale entries.
  • I only populated missing entries; in the case of conflicts I did not change anything
  • This is the frFR locale entries - this is split into multiple PR to prevent too large SQL files

Issues Addressed:

  • Closes unreported issue

SOURCE:

broadcast_text_locale data

Tests Performed:

  • N/A

How to Test the Changes:

  1. Use not enUS client and see gossip menu options now have before missing locale data

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

ZhengPeiRu21 avatar Jul 22 '22 15:07 ZhengPeiRu21

Testing IG and work for the french version. Thanks :)

ghost avatar Jul 28 '22 16:07 ghost