azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(Core/SAI): Fix Kaw the Mammoth Destroyer quest

Open Asthalor opened this issue 2 years ago • 6 comments

Changes Proposed:

  • Fixed some smartAi events that were wrong
  • Made possible to finish the quest by making the Tauren attackable after killing the mount.
  • Changed the class Unit.cpp to fix a bug that made the mammoth used as a mount uncontrollable after some seconds, forcing you to wander as a creature. Patch found here (https://github.com/TrinityCore/TrinityCore/issues/22368) and reburbished to work on AC.

Co-authored-by: Wyrserth [email protected]

Issues Addressed:

  • Closes https://github.com/azerothcore/azerothcore-wotlk/issues/12054

SOURCE:

https://www.wowhead.com/quest=11879/kaw-the-mammoth-destroyer

Tests Performed:

  • .add quest 11879
  • Check that you can mount a Wooly Mammoth Bull and that the skills work
  • Check that after coming close to the creature the event starts, he yells and jump into the mammoth.
  • Check that fter killing the mamoth you can kill him properly, and on death he drops the weapon to finish the quest.

Known Issues and TODO List:

  • Im using player near instead of the prefered areatrigger condition. Even though the areatrigger was reached i could not make him to do the event.
  • When he is dead a yellow message and a warning sound should pop with the text "Kaw`s halberd breaks in two and falls to the ground" but i couldnt see how to make it on SAI.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Asthalor avatar Jun 30 '22 11:06 Asthalor

I am famliar with this pr. this is a pretty important core wide change. @azerothcore/testers

acidmanifesto avatar Jul 01 '22 15:07 acidmanifesto

Before merge this, please add this to the commit message. Co-authored-by: Wyrserth <[email protected]>

Nefertumm avatar Jul 09 '22 21:07 Nefertumm

Tested @Asthalor :

  • [X] You can mount a Wooly Mammoth
  • [X] Skills seems work
  • [X] When you are near Kaw, he yell and mount Moria
  • [X] When Moria die, you jump and you can target him

One issue: How do you kill moria ? Skills of Wooly don't affect him. And I can't target Moria with my spells or auto-attack. I used .damage to continue the test.

ghost avatar Jul 13 '22 20:07 ghost

Thanks @Maelthyrr , Weird, on my testing i could use the skills to kill moira. I will check it out to see how it breaks.

Asthalor avatar Jul 17 '22 09:07 Asthalor

status?

Nefertumm avatar Aug 01 '22 20:08 Nefertumm

Im still to check it, busy weeks. :(

Asthalor avatar Aug 04 '22 06:08 Asthalor

Status of this PR? No movement or followup since August 4th.

acidmanifesto avatar Oct 20 '22 13:10 acidmanifesto

Sorry, but im not able to finish the issue with this pr, some other developer can take a look or we can close it.

Asthalor avatar Oct 20 '22 17:10 Asthalor

I'm finishing this SQL, the quest will be fixed soon 👍

Dr-Arayashiki avatar Nov 26 '23 03:11 Dr-Arayashiki