12037 phalanx location

[cip123]

Issues Addressed:

• Closes https://github.com/azerothcore/azerothcore-wotlk/issues/12037

Tests Performed:

• It compiles and I tested this change on MacOs

How to Test the Changes:

1. As a GameMaster type .go c 46615
2. Buy 6 dark iron ale mugs which from Plugger Spazzring (the gnome with a wizard hat) angry.
3. Give the 6 mugs to Rocknot. He will become drunk, break the kegs and that will upset Phalanx.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[noisiver]

There shouldn't be acore_world. in the sql queries as not everyone uses that name for their world database.

[acidmanifesto]

@azerothcore/testers

[acidmanifesto]

@cip123 how were the positions gps obtained in this pr?

[cip123]

@cip123 how were the positions gps obtained in this pr?

I used GM mode to position myself in BRD and got the GPS locations.

[ghost]

Tested and work. Maybe one suggestion, it's seems that phalanx yell something during the path, could you see and add this if it's true? It's to avoid another PR just for one emote...

[acidmanifesto]

@cip123 how were the positions gps obtained in this pr?

I used GM mode to position myself in BRD and got the GPS locations.

so you only reused the exsisting gps already?

[cip123]

No, I approximated new GPS locations by positioning myself in the corner and then at the door.

On Mon, Jul 4, 2022 at 7:57 PM acidmanifesto @.***> wrote:

@cip123 https://github.com/cip123 how were the positions gps obtained in this pr?

I used GM mode to position myself in BRD and got the GPS locations.

so you only reused the exsisting gps already?

— Reply to this email directly, view it on GitHub https://github.com/azerothcore/azerothcore-wotlk/pull/12127#issuecomment-1174005733, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL6GPFLZLXUXCJGWKEFBUDVSMJX3ANCNFSM5ZJ35PUA . You are receiving this because you were mentioned.Message ID: @.***>

[Gultask]

Spawn location:

[3] Position: X: 847.84796 Y: -230.06673 Z: -43.61398
[3] Orientation: 1.640609502792358398

Path:

-- Pathing for Phalanx Entry: 9502
SET @NPC := XXXXXX;
SET @PATH := @NPC * 10;
DELETE FROM `creature_addon` WHERE `guid`=@NPC;
INSERT INTO `creature_addon` (`guid`,`path_id`,`mount`,`bytes1`,`bytes2`,`emote`,`visibilityDistanceType`,`auras`) VALUES (@NPC,@PATH,0,0,1,0,0, '');
DELETE FROM `waypoint_data` WHERE `id`=@PATH;
INSERT INTO `waypoint_data` (`id`,`point`,`position_x`,`position_y`,`position_z`,`orientation`,`delay`,`move_type`,`action`,`action_chance`,`wpguid`) VALUES
(@PATH,1,865.3834,-219.31128,-43.7037,0,0,0,0,100,0),
(@PATH,2,867.29456,-222.6452,-43.72592,0,0,0,0,100,0),
(@PATH,3,867.29456,-222.6452,-43.72592,2.007128715515136718,0,0,0,100,0);

[ghost]

@cip123 is it abandon ?

[cip123]

No, I'll take care of it.

[cip123]

I updated the coordinates to what @Gultask added. The spawn location looks good. However, there are two issues with the waypoint_data.

1. Phalanx is walking instead of running; this can be fixed by replacing move_type= 0 with move_type=2.
2. Phalanx is not turning to face the room once it stops at the doorway. This was an issue that I also encountered while testing my previous coordinates. I fixed this by making him go one step further and then returning. It looks like the current path implementation does not allow turning in place.

@Maelthyrr Please let me know if any suggestions regarding this.

[cip123]

@acidmanifesto Please see my previous comment: https://github.com/azerothcore/azerothcore-wotlk/pull/12127#issuecomment-1220869655

[acidmanifesto]

@acidmanifesto Please see my previous comment: #12127 (comment)

i am not entirely certain what this has to do with me.

[acidmanifesto]

Marking as WIP, please address the reviews and update the PR.

[Nyeriah]

Hey @cip123 why close this?

[cip123]

As I explained in the PR, I couldn't implement the sniffed coordinates because the creature can't change its orientation without moving (it can't turn in place).

I tried to ask for help but to no avail.

I am sure somebody else can handle it better.