Keira3 icon indicating copy to clipboard operation
Keira3 copied to clipboard

Add the waypoint_data table

Open pangolp opened this issue 6 months ago • 13 comments

It's likely there will be some errors, as this is my first time working with the editor. The idea was to add the waypoint_data table. If you see any errors, please let me know so I can try to correct them. If everything goes well, the plan is to continue with the other three tables mentioned in the issue.

I haven't been able to test it on Windows because I'm getting an error. Although I have what you mention installed because I compile the emulator. And without that, it wouldn't compile; perhaps it's missing something else.

Error running npm install
npm warn skipping integrity check for git dependency ssh://[email protected]/electron/node-gyp.git
npm warn deprecated @types/[email protected]: This is a stub types definition. electron-settings provides its own type definitions, so you do not need this installed.
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: this library is no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: No longer maintained
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm warn deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
npm warn cleanup Failed to remove some directories [
npm warn cleanup   [
npm warn cleanup     '\\\\?\\C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@nx\\webpack\\node_modules',
npm warn cleanup     [Error: EPERM: operation not permitted, rmdir 'C:\Users\Walter\Desktop\keira3\node_modules\@nx\webpack\node_modules'] {
npm warn cleanup       errno: -4048,
npm warn cleanup       code: 'EPERM',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: 'C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@nx\\webpack\\node_modules'
npm warn cleanup     }
npm warn cleanup   ],
npm warn cleanup   [
npm warn cleanup     '\\\\?\\C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@angular-devkit',
npm warn cleanup     [Error: EPERM: operation not permitted, rmdir 'C:\Users\Walter\Desktop\keira3\node_modules\@angular-devkit\build-angular\node_modules\@angular\build\node_modules'] {
npm warn cleanup       errno: -4048,
npm warn cleanup       code: 'EPERM',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: 'C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@angular-devkit\\build-angular\\node_modules\\@angular\\build\\node_modules'
npm warn cleanup     }
npm warn cleanup   ],
npm warn cleanup   [
npm warn cleanup     '\\\\?\\C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@module-federation\\utilities',
npm warn cleanup     [Error: EPERM: operation not permitted, rmdir 'C:\Users\Walter\Desktop\keira3\node_modules\@module-federation\utilities\node_modules'] {
npm warn cleanup       errno: -4048,
npm warn cleanup       code: 'EPERM',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: 'C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\@module-federation\\utilities\\node_modules'
npm warn cleanup     }
npm warn cleanup   ]
npm warn cleanup ]
npm error code 1
npm error path C:\Users\Walter\Desktop\keira3\node_modules\sqlite3
npm error command failed
npm error command C:\Windows\system32\cmd.exe /d /s /c prebuild-install -r napi || node-gyp rebuild
npm error prebuild-install warn This package does not support N-API version undefined
npm error (node:3408) [DEP0176] DeprecationWarning: fs.R_OK is deprecated, use fs.constants.R_OK instead
npm error (Use `node --trace-deprecation ...` to show where the warning was created)
npm error prebuild-install warn install No prebuilt binaries found (target=undefined runtime=napi arch=x64 libc= platform=win32)
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | win32 | x64
npm error (node:19224) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
npm error (Use `node --trace-deprecation ...` to show where the warning was created)
npm error (node:19224) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
npm error gyp info find Python using Python version 3.12.4 found at "D:\Users\Walter\AppData\Local\Programs\Python\Python312\python.exe"
npm error gyp ERR! find VS
npm error gyp ERR! find VS msvs_version not set from command line or npm config
npm error gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
npm error gyp ERR! find VS checking VS2022 (17.11.35219.272) found at:
npm error gyp ERR! find VS "D:\Program Files\Microsoft Visual Studio\2022\Community"
npm error gyp ERR! find VS - found "Visual Studio C++ core features"
npm error gyp ERR! find VS - found VC++ toolset: v143
npm error gyp ERR! find VS - missing any Windows SDK
npm error gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
npm error gyp ERR! find VS looking for Visual Studio 2015
npm error gyp ERR! find VS - not found
npm error gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
npm error gyp ERR! find VS
npm error gyp ERR! find VS **************************************************************
npm error gyp ERR! find VS You need to install the latest version of Visual Studio
npm error gyp ERR! find VS including the "Desktop development with C++" workload.
npm error gyp ERR! find VS For more information consult the documentation at:
npm error gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
npm error gyp ERR! find VS **************************************************************
npm error gyp ERR! find VS
npm error gyp ERR! configure error
npm error gyp ERR! stack Error: Could not find any Visual Studio installation to use
npm error gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\find-visualstudio.js:122:47)
npm error gyp ERR! stack     at C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\find-visualstudio.js:75:16
npm error gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\find-visualstudio.js:363:14)
npm error gyp ERR! stack     at C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\find-visualstudio.js:71:14
npm error gyp ERR! stack     at C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\find-visualstudio.js:384:16
npm error gyp ERR! stack     at C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\util.js:54:7
npm error gyp ERR! stack     at C:\Users\Walter\Desktop\keira3\node_modules\sqlite3\node_modules\node-gyp\lib\util.js:33:16
npm error gyp ERR! stack     at ChildProcess.exithandler (node:child_process:422:5)
npm error gyp ERR! stack     at ChildProcess.emit (node:events:507:28)
npm error gyp ERR! stack     at maybeClose (node:internal/child_process:1101:16)
npm error gyp ERR! System Windows_NT 10.0.19045
npm error gyp ERR! command "D:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\sqlite3\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
npm error gyp ERR! cwd C:\Users\Walter\Desktop\keira3\node_modules\sqlite3
npm error gyp ERR! node -v v24.1.0
npm error gyp ERR! node-gyp -v v8.4.1
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: C:\tmp\nodejs\npm-cache\_logs\2025-06-06T04_12_07_691Z-debug-0.log

https://github.com/azerothcore/Keira3/issues/3061

pangolp avatar Jun 06 '25 03:06 pangolp

Did you run npm install --global-production windows-build-tools and did you restart the PC afterward?

Helias avatar Jun 08 '25 17:06 Helias

Did you run npm install --global-production windows-build-tools and did you restart the PC afterward?

I think not, I will review it. Thank you.

pangolp avatar Jun 08 '25 20:06 pangolp

Regarding the error, I'm updating Visual Studio, and if I remember correctly, when performing the installation, it recommends tools to work in node.js, which I probably won't install, because at the moment, I haven't had to use them, so I'm going to try adding those tools and using the command you sent me above.

pangolp avatar Jun 09 '25 01:06 pangolp

When I run this command it seems to work, but I had to delete a file: package-lock.json That file, however, is generated when the command is run. But Git has it in the history, so it asks me to upload it.

$ git status
On branch waypoints_data
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")
npm install
C:\Users\Walter\Desktop\keira3>npm install
npm warn skipping integrity check for git dependency ssh://[email protected]/electron/node-gyp.git
npm warn deprecated @types/[email protected]: This is a stub types definition. electron-settings provides its own type definitions, so you do not need this installed.
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: this library is no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated [email protected]: No longer maintained
npm warn deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm warn deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
npm warn cleanup Failed to remove some directories [
npm warn cleanup   [
npm warn cleanup     'C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\dmg-license\\node_modules\\json-schema-traverse',
npm warn cleanup     [Error: EPERM: operation not permitted, rmdir 'C:\Users\Walter\Desktop\keira3\node_modules\dmg-license\node_modules\json-schema-traverse\spec\fixtures'] {
npm warn cleanup       errno: -4048,
npm warn cleanup       code: 'EPERM',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: 'C:\\Users\\Walter\\Desktop\\keira3\\node_modules\\dmg-license\\node_modules\\json-schema-traverse\\spec\\fixtures'
npm warn cleanup     }
npm warn cleanup   ]
npm warn cleanup ]

> [email protected] postinstall
> electron-builder install-app-deps

  • electron-builder  version=26.0.12
  • loaded configuration  file=C:\Users\Walter\Desktop\keira3\electron-builder.json
  • executing @electron/rebuild  electronVersion=34.5.3 arch=x64 buildFromSource=false appDir=./
  • installing native dependencies  arch=x64
  • preparing       moduleName=sqlite3 arch=x64
  • finished        moduleName=sqlite3 arch=x64
  • completed installing native dependencies

> [email protected] prepare
> husky install

husky - install command is DEPRECATED

added 2069 packages, and audited 2070 packages in 5m

298 packages are looking for funding
  run `npm fund` for details

24 vulnerabilities (22 moderate, 1 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

pangolp avatar Jun 09 '25 02:06 pangolp

I managed to run the project, but I don't see the table. I must be missing it somewhere.

pangolp avatar Jun 09 '25 02:06 pangolp

I needed to add it to the sidebar, but I don't know if it should be in the creature section. Maybe it should be somewhere else. When you can review it, based on the corrections, I'll try to fix the errors.

image

image

pangolp avatar Jun 09 '25 22:06 pangolp

I would stick with translating the attributes within the component, although really, I don't know if it's a good thing, for me, the attributes have to be respected and remain in English, it would be good to add information in the last placeholder in the different languages, so that the person knows what they have to complete in that field, but if they prefer to translate the attribute, I have no problem doing so.

pangolp avatar Jun 09 '25 22:06 pangolp

I think it should be removed from creature, because it seems to me that in this case, they are not related, although I don't really remember, perhaps the ID is the ID of the creature table, that is, the guid. The truth is, I haven't used the table for a long time.

pangolp avatar Jun 09 '25 22:06 pangolp

id: Unique ID for each path.

The TDB standard way of assigning an ID is to multiply GUID of the creature by 10. So for a creature with a GUID of 1234 the path ID would be 12340. Any waypoints submitted to TDB should follow this standard. However, this is only a suggestion when creating your own waypoints. This ID can be anything you want as long as creature_addon.path_id is set to the ID you pick here for the creature you are creating a waypoint for.

https://www.azerothcore.org/wiki/waypoint_data

pangolp avatar Jun 09 '25 22:06 pangolp

Let's keep the field name as is in the db, so in English.

About where to put the editor, let's move to a separate section like "Others ..."

Helias avatar Jun 10 '25 08:06 Helias

Thanks for your contribution! Can you please add the unit tests?

FrancescoBorzi avatar Jun 18 '25 11:06 FrancescoBorzi

Thanks for your contribution! Can you please add the unit tests?

I'll try it. To do so, I need to delete the package-lock.json file, otherwise it won't download all the dependencies and won't start the project.

pangolp avatar Jun 18 '25 11:06 pangolp

I need help with the last change that I have to make. The ID of this table would have to be, the guid of the creature, multiplied by 10. The problem, is that I am accessing from Creature_Template, not from Creature. Since in the waypoint_data, the creature's guid is used, and to that value, it is multiplied by 10. I am really lost. I don't know very well that I have to modify.

pangolp avatar Jun 22 '25 17:06 pangolp

I'm going to have to close this PR. Although I've made great progress, there are still several changes I need to implement due to my lack of knowledge. Perhaps they can serve as a basis for others in the future.

pangolp avatar Jul 29 '25 11:07 pangolp